- OpenStack-I18n - lists.openstack.org

Ironic's .po files contain only blank msgstr's
by Devananda van der Veen 31 Mar '14

31 Mar '14

Hi all, I recently noticed that none of the ironic/locale/*/LC_MESSAGES/ironic.po files contain any translated strings, even though Jenkins is routinely proposing updates. I looked a bit further into this, with a few pointers from Clark, and it seems that the jenkins translation job is erroring out. It claims there's a duplicate message, but I haven't been able to figure out why. I've filed a bug here: https://bugs.launchpad.net/ironic/+bug/1298645 For quick reference, here's a link to the errors that we think are the cause of this issue: http://logs.openstack.org/periodic/ironic-propose-translation-update/6aed39… Then, today, I noticed that the same error also shows up in Nova and Ceilometer's recent jobs. Here's an example from Nova. http://logs.openstack.org/8d/8df565d39cd3216bde8488e656957a49dd6949fa/post/… I could use some help figuring this out. Since folks have been translating strings for Ironic, I'd really like to be able to include that work in our Icehouse release :) Thanks much, Devananda

4 6

Clarifying String Freeze
by Julie Pichon 31 Mar '14

31 Mar '14

Hi all, During the weekly Horizon meeting [0], a few questions from the Horizon team came up about String Freeze. I think the wiki page on String Freeze [1] at the moment does not match the wishes of the translation team, based on previous conversations [2]. It would be really helpful if the wiki page could be updated to match what the i18n team would prefer. At the moment, in Horizon it seems what we're doing, and planning on doing, is this (somewhat similar to what happened in Havana): - During String Freeze and until RC1, small string changes are ok (Horizon core can just approve) - During String Freeze, string changes in the "grey zone" should use the exception approval process on the wiki (email to i18n list) - After RC1 is released, every string change should follow the exception approval process on the wiki (email to i18n list) ??? - this isn't clearly defined yet, maybe it needs to be earlier? Point #3 is about when the "soft freeze" needs to become a "hard freeze". What is the grey zone? I'm not entirely sure either. An example was: adding several new strings for what could be considered a "mini-feature", during the RC period. Perhaps we can start with this kind of examples + "when in doubt, ask on the i18n list" to define what is the grey zone. In general, I think updating the wiki page would really help reviewers assess patches with a clearer understanding of what is helpful to the i18n/translation team during string freeze, and what might require exception approval or more discussion. Thank you, Julie [0] http://eavesdrop.openstack.org/meetings/horizon/2014/horizon.2014-03-25-16.… [1] https://wiki.openstack.org/wiki/StringFreeze [2] http://lists.openstack.org/pipermail/openstack-dev/2014-March/029868.html

3 2

Translate Horizon for Icehouse version
by Ying Chun Guo 31 Mar '14

31 Mar '14

Hello, It's very near the release of Icehouse now. We need help on the translation of Horizon, especially to the following languages: Portuguese, French, Dutch, Russian, Spanish, Traditional Chinese Polish. The translation of these languages are very near to the goal, only hundreds of strings left. Other languages are welcome too. If you want to help, go to https://www.transifex.com/projects/p/horizon/resource/openstack-dashboard-t… https://www.transifex.com/projects/p/horizon/resource/horizon-translations/ https://www.transifex.com/projects/p/horizon/resource/horizon-js-translatio… If the translation can be 100% done before April 10th, it will be shipped with OpenStack Icehouse. If you have questions, go to IRC channel #openstack-translation, or attend our IRC meeting at March 20th 0000 UTC in the channel of #openstack-meeting. Best regards Ying Chun Guo (Daisy)

8 8

Polish translation ready
by Łukasz Jernaś 29 Mar '14

29 Mar '14

Hi, The Polish translation is ready for Icehouse release. There's one string I'm not happy with (Disk over commit), but at least it's readable for admins. Sorry it took so long :( Best regards, -- Łukasz [DeeJay1] Jernaś

1 0

German horizon translation complete
by Sascha Peilicke 28 Mar '14

28 Mar '14

According to https://www.transifex.com/projects/p/horizon/translate/#de, the German horizon translation is at 100%. It certainly isn't perfect yet, there are some orthographic issues to hunt down and we have to agree on some common style (i.e. work on a dictionary). However, we're confident that it could go into Icehouse in it's current state already. Thanks to everybody that participated in this amazingly fast translation sprint! -- Viele Grüße, Sascha Peilicke

3 2

Traditional Chinese translation has been completed
by 張效維 27 Mar '14

27 Mar '14

Hi all: We has finished the Traditional Chinese translation to 100% since last POT upgrade. https://www.transifex.com/projects/p/horizon/language/zh_TW/ Last POT upgrade has deleted some unperfect translated words. So that our work are good enough. From Xiaowei -- NTHU Xiaowei +886-928337382 zero00072(a)gmail.com

1 0

Horizon upstream_translation_update Jenkins job
by Akihiro Motoki 26 Mar '14

26 Mar '14

Hi Daisy, Perhaps RC1 may be shipped this week and the master branch will be opened to Juno development. Even after the master branch is opened to Juno, Transifex resources are still targeted to Icehouse translations. We need to disable upstream_translation_update for Horizon temporarily. Otherwise Transifex resources will be synced with Juno code. Could you coordinate it with the infra team? At now Horizon is the only project whose translation work is being done synced with the release cycle and we tend to encounter the first thing :-( Thanks, Akihiro

2 2

Horizon translations - and update of strings
by Andreas Jaeger 24 Mar '14

24 Mar '14

Looking at my patch to import back the Horizon translations (https://review.openstack.org/#/c/82176) and the comments by Akihiro Motoki, I notice that horizon has no command to update the message catalogs. For all other projects, we basically do the following as part of the propose job: * Download all translation PO files from transifex * Update POT file * Update PO files based on pot file ("python setup.py update_catalogs") * Upload POT and PO files to transifex Horizon does not implement update_catalogs at all. Is this step really needed or is something that transifex does for us and thus we could remove the step? Andreas -- Andreas Jaeger aj(a){suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126

3 6

Re: [Openstack-i18n] .tx in git repository
by Sascha Peilicke 23 Mar '14

23 Mar '14

Sorry for replying a bit late, I just recently joined the list. Meanwhile, .tx was removed from openstack-manuals. However, I think the points raised by Akihiro Motoki haven't been answered. Previously unaware of this discussion, I submitted https://review.openstack.org/#/c/81839/. In short, .tx/config should really be versioned since it contains repo-specific file-paths. While of course this can be autogenerated in the infra job, it doesn't help people that want to use local tools (such as vi / $FAVORITE_PO_EDITOR) instead of the Transifex web-interface. This also raises the side-question if it is acceptable to submit reviews that add translations or if those should somehow be imported into Transifex web instead and fetched via the infra job? -- Viele Grüße, Sascha Peilicke

3 5

German translation team changes
by Sascha Peilicke 20 Mar '14

20 Mar '14

Hi guys, I recently took over coordination of the German translation team on Transifex after the previous coordinator didn't show any activity anymore. I'm an engineer from SUSE and contributed to the German translation before. I also took the liberty to add two of my colleagues as reviewers. Both have added to the German translations before and we didn't have any reviewers before. -- Viele Grüße, Sascha Peilicke

2 1

transifex problems
by Andreas Jaeger 19 Mar '14

19 Mar '14

Looking at current translations, I see messages like: Pushing 'en_GB' translations (file: keystone/locale/en_GB/LC_MESSAGES/keystone.po) https://www.transifex.com/api/2/project/keystone/resource/keystone-translat… Error uploading file: There is a syntax error in your file. Line 1962: duplicate message definition... Line 7: ...this is the location of the first definition msgfmt: found 1 fatal error This happens for example in: https://jenkins.openstack.org/job/keystone-upstream-translation-update/1354… Has anybody an idea? Andreas -- Andreas Jaeger aj(a){suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126

1 0

[keystone] string freeze exceptions
by Dolph Mathews 19 Mar '14

19 Mar '14

I want to open with an apology, because I just found out that new strings (additions) during freeze are not acceptable under the terms of string freeze -- I have mistakenly lead keystone-core into believing that additions were fine. From now on I'll work to correct that! On the other hand, I hope we've done a decent job in code review to protect the translation team from *changes* to translatable strings. As I just discovered this list (and it appears to be fairly new), I'm making the assumption that https://wiki.openstack.org/wiki/StringFreezeshould be revised to direct exceptions to this list instead of -dev? I believe the only addition we currently have in review prior to RC is this one, which is about ready to start gating: https://review.openstack.org/#/c/81385/ The new string is identical to an existing string, excluding the possibility for any exception information to be appended via string formatting. Thanks! -Dolph

1 0

IRC meeting tomorrow
by Ying Chun Guo 18 Mar '14

18 Mar '14

Hello, We will have our IRC meeting tomorrow at UTC 0000 in IRC channel "#openstack-meeting". In my mind, we will: * Follow up with the Horizon translation and collect issues if you have. * Introduce the font setting of doc maven build tool * Figure out work items remained about installation guide translation & publishing. If you have other topics, welcome to bring up. Thanks and regards Ying Chun Guo (Daisy)

1 0

Re: [Openstack-i18n] Fw: [OpenStack-doc] Add Korean fonts for 'coluddoc-maven-plugins'
by Ying Chun Guo 18 Mar '14

18 Mar '14

Hi, Sungjin Can you give the font file or the link to download the font file to David Cramer? He can add it to the plugin and cut a release. @ the whole team If you have font issue with the Maven plugin, please send your font file to David Cramer. @ David Will the Maven plugin become very big if it contains so many font files? Is it possible to use system font instead? Is it possible to configure which font to download when downloading the binary plugin files? Regards Ying Chun Guo (Daisy) David Cramer <david.cramer(a)rackspace.com> wrote on 2013/08/13 03:13:14: > David Cramer <david.cramer(a)rackspace.com> > 2013/08/13 03:13 > > To > > Ying Chun Guo/China/IBM@IBMCN, > > cc > > Subject > > Re: Fw: [Openstack-i18n] [OpenStack-doc] Add Korean fonts for > 'coluddoc-maven-plugins' > > Hi Daisy, > So I'm surprised that those steps would work. You'd really have to do > "mvn clean install" to make a changed version of the plugin available > for local builds (and also be sure that your project depends on the > version you just built). > > In the thread below, Sungjin Gang had a message to me offering to > provide a Korean font file. I think I'd replied saying that if I were > given the file , I could add it to the plugin. Is there an open source > font file available somewhere that I can download? If so, I'll add it > immediately and cut a release. > > For each language that requires a special font, we'll have to add the > font to the plugin for it to work. > > Regards, > David > > On 08/12/2013 11:46 AM, Ying Chun Guo wrote: > > Hi, David > > > > Sungjin Gang is a Korean translator. When he was trying to generate the > > translated Korean documents, he found the Korean characters cannot be > > displayed and #### was displayed instead of Korean font. > > > > After several tests, he tried follow steps and had Korean font work. > > > >> Edit 'clouddoc-maven-plugins'[1]. > >> Recompiling plugin. > >> Edit 'openstack-manuals/[docs-name]/pom.xml', plugin dir. > >> and exe 'mvn clean generate-sources'. > >> Create PDF[2]. > > > > As I remembered, there was the same problem to Chinese and Japanese > > characters, and now there was problem for Korean characters. I wonder if > > there are same problems to other languages. I'd like to check with you > > if you have any thoughts to resolve the root of this issue, other than > > using this tricky way. > > > > Thanks and regards > > Ying Chun Guo (Daisy) > > > > ----- Forwarded by Ying Chun Guo/China/IBM on 2013/08/13 00:39 ----- > > > > Sungjin Gang <gang.sungjin(a)gmail.com> wrote on 2013/08/10 15:04:57: > > > >> Sungjin Gang <gang.sungjin(a)gmail.com> > >> 2013/08/10 15:04 > >> > >> To > >> > >> Ying Chun Guo/China/IBM@IBMCN, > >> > >> cc > >> > >> openstack-i18n(a)lists.openstack.org > >> > >> Subject > >> > >> Re: [Openstack-i18n] [OpenStack-doc] Add Korean fonts for 'coluddoc- > >> maven-plugins' > >> > >> Hi, ~~~ > >> > >> :)) > >> > >> View Korean font!!!!! > >> :)) > >> > >> Edit 'clouddoc-maven-plugins'[1]. > >> > >> Recompiling plugin. > >> > >> Edit 'openstack-manuals/[docs-name]/pom.xml', plugin dir. > >> > >> and exe 'mvn clean generate-sources'. > >> > >> Create PDF[2]. > >> > >> Um.. hahahahahahaaaaaaa~ :)) > >> > >> But not think to do it. hahahahahahahaaaaaaaaaa :-( > >> > >> [image removed] > >> > >> [1]: https://github.com/ujuc/clouddocs-maven-plugin/commit/ > >> cb0743a14ece9e86cdcb190e778a9f38319b5b9a > >> [2]: http://os.ujuc.kr/openstack-manuals/generated/ko_KR/basic- > >> install/target/docbkx/webhelp/grizzly/basic-install/apt/openstack- > >> basic-install-apt-grizzly.pdf > >> > >> Thanks, > >> Sungjin. > >> > >> Jul 30, 2013, 5:34 PM, Ying Chun Guo <guoyingc(a)cn.ibm.com> $)C작성: > >> > >> Hi, > >> > >> It seems that I have met with this problem before, but I cannot > >> remember how I resolve it. It was a long time ago. > >> > >> @amotoki and KATO, have you met with this problem and how did you > > resolve it? > >> > >> Regards > >> Ying Chun Guo (Daisy) > >> > >> ----- Forwarded by Ying Chun Guo/China/IBM on 2013/07/30 16:32 ----- > >> > >> Sungjin Gang <gang.sungjin(a)gmail.com> wrote on 2013/07/21 23:01:33: > >> > >> > Sungjin Gang <gang.sungjin(a)gmail.com> > >> > 2013/07/21 23:01 > >> > > >> > To > >> > > >> > david.cramer(a)rackspace.com, > >> > > >> > cc > >> > > >> > Openstack-i18n <openstack-i18n(a)lists.openstack.org>, openstack- > >> > docs(a)lists.openstack.org > >> > > >> > Subject > >> > > >> > [Openstack-i18n] [OpenStack-doc] Add Korean fonts for 'coluddoc- > >> maven-plugins' > >> > > >> > Hi, David > >> > > >> > This is Sungjin Kang, a coordinator of OpenStack I18N Korean Team. > >> > Could you help me out on the following problem? > >> > > >> > When creating a korean document using maven, all korean characters > >> > are displayed as "#####". > >> > > >> > While I was looking for the possible solution, I found out that > >> > Korean font might need to be added in "clouddoc-maven-plugins" > > youmanages. > >> > > >> > If this is the case (adding korean font), I would like to add a > >> > korean font called "Nanum fonts[1]" > >> > > >> > [1] http://en.wikipedia.org/wiki/Nanum_font > >> > > >> > I can prepare for the actual font file. However, I don't know what I > >> > need to do to add korean font. > >> > > >> > Could you help me out on this? > >> > > >> > Thanks, > >> > > >> > Sungjin Gang_______________________________________________ > >> > Openstack-i18n mailing list > >> > Openstack-i18n(a)lists.openstack.org > >> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-i18n > >> _______________________________________________ > >> Openstack-i18n mailing list > >> Openstack-i18n(a)lists.openstack.org > >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-i18n > > >

3 7

Translation jobs running again
by Andreas Jaeger 17 Mar '14

17 Mar '14

We now have properly working translation jobs for api-site, openstack-manuals and operations-guide. There are two kind of jobs: The upstream-translation jobs that is run in the post-queue - so after a change is approved - that generates the pod files and sends them to transifex for translation. And the propose-translation jobs that run in the periodic queue - once every morning (starting at 6:00 UTC) - where transifex is queried for any change and these are then proposed as patch for the project. We just got the first three propose-translation jobs in the queue for review with an initial import. We will get now updated pot files if our sources changed and updated po files if translators update strings. Just approve them. Hope everything is working fine now, if not, please tell on the mailing lists. Especially if you see one of these jobs failing, please reach out so that it gets fixed. Andreas -- Andreas Jaeger aj(a){suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126

1 0

Track .tx in git or not?
by Ying Chun Guo 12 Mar '14

12 Mar '14

Hello, The folder .tx is used to save the configuration of Transifex Client, which supports our translation process. The folder .tx in openstack-manuals is in managed by git index and tracked changes by git. The file .tx/config saves the mapping information between local po files and the resources in Transifex. If a new po file is added, the file .tx/config will be changed. Now the changes of folder .tx will cause a failure of the job propose_translation_update_manuals. I'm going to fix it. Both of below two ways work: removing .tx from git tree and index, or changing propose_translation_update_manuals.sh to track changes in .tx. I just don't know which one is the better choice. Removing .tx from git because: .tx has no relationship with openstack-manuals. The scripts propose_translation_update_manuals.sh and upstream_translation_update_manuals.sh can use command lines to create and edit the configurations. Tracking .tx in git because: when some people want to use Transifex Client to manage po files, with .tx, they can use simple Transifex Client command line to pull the translations, and don't need to understand the complex mapping information. There is no consensus in OpenStack projects. Some projects don't track and some projects track. I think we need a consensus at least within all documentation projects. I prefer the first opinion - removing .tx from git Please let me know your thoughts to this question. Thank you. Best regards Ying Chun Guo (Daisy)

3 7

Hindi/ Tamil Internationalization efforts
by Sriram Subramanian 12 Mar '14

12 Mar '14

Hello i18n team: I see that there is an entry for Hindi, but there's none listed as coordinator. Is anybody working that ? I also wanted to know if there is any interest in starting efforts for Tamil. How to get started? -- Thanks, -Sriram

3 3

Let's translate horizon for Icehouse!
by Akihiro Motoki 09 Mar '14

09 Mar '14

Hi I18N team, Icehouse-3 milestone has been shipped and it is time to start Horizon translation for Icehouse. Horizon resources on Transifex are now synced with Horizon Git repository automatically. Once a patch is approved and merged, new strings are pushed to Transifex if necessary. Thanks Daisy for the automated script. Let's visit https://www.transifex.com/projects/p/horizon/resources/ and translate! Resources *without* "Havana" are translation targets for Iceshouse. [Translation Import Date] It is not actually decided yet because Horizon RC1 date is not determined yet. According to Icehouse release schedule, RC period begins a week of Mar 27th. Only I can say is the first target date is the beginning of the week of Mar 27th (around Mar 24). Even if your translation is not completed by the date, we have another chance to import translations for Icehouse release (such RC2 or ...). I will update the date if I have an update. [Translation check site] As I did in Havana cycle, I will run translation check site. There is no change in the host and account information from Havana site. (It means my translation check site is switched to Icehouse version) http://157.7.133.23:13580/ Username: demo / admin, Password: opstjpHavana * Translations are imported from Transifex every hour. * Sometimes I will update devstack and latest codes from the official repos. * If something looks wrong, please let me know. Enjoy Icehouse version of OpenStack Dashboard!! Note that it is hosted on a virtual server donated to Japan OpenStack Users Group by GMO internet. Thanks. Cheers, Akihiro

6 5

Gating on string changes
by Łukasz Jernaś 06 Mar '14

06 Mar '14

Hi, continuing from todays meeting as I got caught up in work stuff (sorry Julie) So the idea was that changes on stable/* and milestone/proposed would run an additional gate job which would check for changes in strings and if they detect one would add a -1 review on the patchset in gerrit a new category. An i18n team member could accept the freeze exception by adding a +1 and only changes with 0 in that gerrit review category would pass or maybe a +1 if we settle on two members. This is modelled loosely on the rules used by the GNOME project (which I'm accustomed to, so forgive me the bias) described here: https://wiki.gnome.org/ReleasePlanning/Freezes https://wiki.gnome.org/TranslationProject/HandlingStringFreezes It just a thought of course, but seeing that the OpenStack project community is more diverse adding gerrit/jenkins checks would be a nice idea as enforcing an "send email" policy could be a lot harder. Best regards, -- Łukasz [DeeJay1] Jernaś

2 1

I18n meeting tomorrow
by Ying Chun Guo 04 Mar '14

04 Mar '14

Hello We will have our I18n meeting tomorrow at 0070 UTC in the channel "openstack-meeting". March starts. We should begin Horizon messages translation and I18n test for Icehouse release now. At the same time, we should conclude the installation guide translation and publish our results to the doc website. Let's discuss about these two topics in this meeting. Thanks and regards Ying Chun Guo (Daisy)

1 0

Korean install guide
by Łukasz Jernaś 24 Feb '14

24 Feb '14

Hi, I see, that I've been called out on the last meeting about the Korean install guide ;) So the problem with that guide has been noted earlier and reported on Launchpad as https://bugs.launchpad.net/openstack-i18n/+bug/1276434. Basically there's a wrong tag in the translated string which makes the maven plugin cry. As I don't have sufficient access to Transifex I can't fix it myself so only project admins or the Korean team can fix the issue. I hope the description in the mentioned bug helps to fix it! Best regards, -- Łukasz [DeeJay1] Jernaś P.S. ujuc if I somehow managed to miss the email from you, I'm sorry...

4 10

Travel Support Program for Summit in Atlanta
by Ying Chun Guo 24 Feb '14

24 Feb '14

Hello, The Atlanta summit will be held from May 12 to May 16 in Atlanta. If you want to attend but you cannot find travel support, you can try this program: https://wiki.openstack.org/wiki/Travel_Support_Program The program is to support the travel of "key contributors" to attend the summit. Key contributors are contributors whose presence is specifically relevant for the topics to be discussed at the Summit they're applying to. Contribution to translation and translation platform is definitely a kind of important contribution. A good idea to enhance our translation platform and translation process could be a candidate of design summit session. The Final deadline to submit applications is March 2nd. After you submit your application, please inform me. I will try my best to help. Thank you and best regards Ying Chun Guo (Daisy)

2 1

IRC meeting tomorrow
by Ying Chun Guo 18 Feb '14

18 Feb '14

Hello all, As the schedule, we will have I18n team meeting at 0000 UTC tomorrow in #openstack-meeting. I don't have many topics, except: * Issues collection and progress check for "Installation guide" translation * Synchronization processes for Horizon messages translation If you have other topics to discussion, please bring up. Let's meet at IRC tomorrow. Best regards Ying Chun Guo (Daisy)

1 0

Here to help about french translation
by Sonny TADJER 14 Feb '14

14 Feb '14

Hello everybody, I do not really know how to introduce myself. it’s been the third time we helped me about openstack so I just put my services to you about french translation. I do not know who to contact exactly (saw this : https://wiki.openstack.org/wiki/I18nTeam) and apparently no translators for french. How sad. So I will try to be on openstack-meeting at 2am tonight :) id : Sonny78

4 5

About "installation guide" translation
by Ying Chun Guo 14 Feb '14

14 Feb '14

@ teams who are translating "installation guide": "Installation guide" has references to a few xml files under the folder "common" in openstack-manuals. While you are translating "installation guide", don't forget these xml files. They are: keystone-concepts.xml kvm.xml qemu.xml introcution-to-xen.xml compute-options.xml ch_installdashboard.xml colocating-services.xml You can locate the strings of these xml files by the following steps: 1. Go to "common" in Transifex, and select your language. https://www.transifex.com/projects/p/openstack-manuals-i18n/resource/common/ 2. In the "search" box (at the top left corner), select "File" and input the xml file name . All the strings in this file will be listed. With the help of Łukasz Jernaś, there is an easy way to review your translation result. Go to website http://docs.przytulnoc.pl/ and select your language, you will see the translated document. There are 2 weeks left in Feb, let's try to complete the translation by this month! Thanks and regards Ying Chun Guo (Daisy)

2 1