Open Stack

Hi!

Good catch. Have no objections for fixing it right now.

Regards,
Kate.


On Thu, Sep 24, 2015 at 10:58 AM, Bulat Gaifullin <bgaifullin at mirantis.com>
wrote:

> +1
>
> > On 24 Sep 2015, at 10:45, Tetiana Lashchova <tlashchova at mirantis.com>
> wrote:
> >
> > Hi folks!
> >
> > Some tests in murano code use incorrect order of arguments in
> assertEqual.
> > The correct order expected by the testtools is
> >
> >         def assertEqual(self, expected, observed, message=''):
> >             """Assert that 'expected' is equal to 'observed'.
> >
> >             :param expected: The expected value.
> >             :param observed: The observed value.
> >             :param message: An optional message to include in the error.
> >             """
> >
> > Error message has the following format:
> >
> > raise mismatch_error
> >     testtools.matchers._impl.MismatchError: !=:
> >     reference = <expected value>
> >     actual    = <observed value>
> >
> > Use of arguments in incorrect order could make debug output very
> confusing.
> > Let's fix it to make debugging easier.
> >
> > Best regards,
> > Tetiana Lashchova
> >
> __________________________________________________________________________
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe:
> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150924/ef4bf33b/attachment.html>