[openstack-dev] [murano] Fix order of arguments in assertEqual

Kekane, Abhishek Abhishek.Kekane at nttdata.com
Thu Sep 24 08:48:59 UTC 2015


Hi,

There is a bug for this, you can add murano projects to this bug.

https://bugs.launchpad.net/heat/+bug/1259292

Thanks,

Abhishek Kekane

-----Original Message-----
From: Bulat Gaifullin [mailto:bgaifullin at mirantis.com] 
Sent: 24 September 2015 13:29
To: OpenStack Development Mailing List (not for usage questions)
Subject: Re: [openstack-dev] [murano] Fix order of arguments in assertEqual

+1

> On 24 Sep 2015, at 10:45, Tetiana Lashchova <tlashchova at mirantis.com> wrote:
> 
> Hi folks!
> 
> Some tests in murano code use incorrect order of arguments in assertEqual.
> The correct order expected by the testtools is
> 
>         def assertEqual(self, expected, observed, message=''):
>             """Assert that 'expected' is equal to 'observed'.
> 
>             :param expected: The expected value.
>             :param observed: The observed value.
>             :param message: An optional message to include in the error.
>             """
> 
> Error message has the following format:
> 
> raise mismatch_error
>     testtools.matchers._impl.MismatchError: !=:
>     reference = <expected value>
>     actual    = <observed value>
> 
> Use of arguments in incorrect order could make debug output very confusing.
> Let's fix it to make debugging easier.
> 
> Best regards,
> Tetiana Lashchova
> ______________________________________________________________________
> ____ OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: 
> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

______________________________________________________________________
Disclaimer: This email and any attachments are sent in strictest confidence
for the sole use of the addressee and may contain legally privileged,
confidential, and proprietary data. If you are not the intended recipient,
please advise the sender by replying promptly to this email and then delete
and destroy this email and any attachments without any further use, copying
or forwarding.



More information about the OpenStack-dev mailing list