<div dir="ltr"><div>Hi!</div><div><br></div>Good catch. Have no objections for fixing it right now.<div><br></div><div>Regards,<br></div><div class="gmail_extra"><div><div class="gmail_signature"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div style="font-size:small">Kate.</div><div><br></div></div></div></div></div></div>
<br><div class="gmail_quote">On Thu, Sep 24, 2015 at 10:58 AM, Bulat Gaifullin <span dir="ltr"><<a href="mailto:bgaifullin@mirantis.com" target="_blank">bgaifullin@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+1<br>
<div><div class="h5"><br>
> On 24 Sep 2015, at 10:45, Tetiana Lashchova <<a href="mailto:tlashchova@mirantis.com">tlashchova@mirantis.com</a>> wrote:<br>
><br>
> Hi folks!<br>
><br>
> Some tests in murano code use incorrect order of arguments in assertEqual.<br>
> The correct order expected by the testtools is<br>
><br>
>         def assertEqual(self, expected, observed, message=''):<br>
>             """Assert that 'expected' is equal to 'observed'.<br>
><br>
>             :param expected: The expected value.<br>
>             :param observed: The observed value.<br>
>             :param message: An optional message to include in the error.<br>
>             """<br>
><br>
> Error message has the following format:<br>
><br>
> raise mismatch_error<br>
>     testtools.matchers._impl.MismatchError: !=:<br>
>     reference = <expected value><br>
>     actual    = <observed value><br>
><br>
> Use of arguments in incorrect order could make debug output very confusing.<br>
> Let's fix it to make debugging easier.<br>
><br>
> Best regards,<br>
> Tetiana Lashchova<br>
</div></div>> __________________________________________________________________________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><br></div></div>