Open Stack

Thanks for the clarification.  I'll bring my thoughts to gerrit in that
case!
On Mar 1, 2016 06:57, "Anita Kuno" <anteaya at anteaya.info> wrote:

> On 03/01/2016 09:39 AM, C.J. Collier wrote:
> > Hello Anita,
> >
> > You bet.  I'll get it in to gerrit shortly.  It's not ready to be merged
> > quite yet.  I just wanted to start a conversation.
>
> I totally understand. Having a conversation before a patch is merged
> makes perfect sense.
>
> For us, that conversation takes place in gerrit on a patch rather than
> on a mailing list in a thread. Gerrit has the option of setting workflow
> -1 on a patch so the owner of the patch can indicate the patch is not
> ready to be merged.
>
> When conversations about patches and approaches take place in gerrit,
> folks who may not have been present for the beginning of the
> conversation are able to see the history of comments on the patch and
> can get themselves up to date. Contributors have become very adept at
> using gerrit to sort patches and follow a conversation as it is ongoing
> for patches in which they are interested.
>
> For instance here is a conversation that has been going on for 2 weeks
> and is on its 10th patchset: https://review.openstack.org/#/c/282295/
>
> Let us know in infra if you have any questions about submitting a
> patchset to gerrit.
>
> Thanks C.J.,
> Anita.
>
> >
> > For instance, would anyone be opposed to using a syslog sink for logging
> > rather than opening up a dedicated file?  There are a lot of files (pid,
> > log, config, channel list) being handled here, and directories for output
> > files (/var/run/gerritbot, /var/log/gerritbot) need to be managed by the
> > init script and kept in sync with the values in the config files.  Fewer
> is
> > better in my opinion, and hooking in to the syslog infrastructure means
> > getting remote logging for no additional cost.  However, for systems
> > without syslog facilities, I guess it make sense to have a dedicated log
> > file.
> >
> > Let me know what you think,
> >
> > C.J.
> > On Mar 1, 2016 00:16, "Anita Kuno" <anteaya at anteaya.info> wrote:
> >
> >> On 03/01/2016 01:22 AM, C.J. Collier wrote:
> >>> Thanks Clark!  I found the same thing.  I've added a few of options
> and a
> >>> dependency on the getopt library.  Take a look at this patch and let me
> >>> know if there's anything you'd like me to add / remove.
> >>>
> >>> Cheers,
> >>>
> >>> C.J.
> >>
> >> Thanks for the patch, C.J.
> >>
> >> We put all our patches up in gerrit for review rather than attaching
> >> diffs to emails, it is just our workflow.
> >>
> >> You might find http://docs.openstack.org/infra/manual/developers.html
> >> interesting as it outlines our workflow including steps to get all the
> >> account signups in order so you can submit a patch to gerrit.
> >>
> >> Thanks for your interest in gerritbot, C.J. We appreciate it.
> >>
> >> Anita.
> >>
> >>>
> >>>
> >>> On Mon, Feb 29, 2016 at 6:47 PM, Clark Boylan <cboylan at sapwetik.org>
> >> wrote:
> >>>
> >>>> On Mon, Feb 29, 2016, at 01:26 PM, C.J. Collier wrote:
> >>>>> Hey folks,
> >>>>>
> >>>>> I'm having a heck of a time getting gerritbot working.  It currently
> >>>>> exits
> >>>>> prematurely without any console output and returns 0 to the calling
> >>>>> process.  No entries in the logs.  Very frustrating.  Can I get some
> >> help
> >>>>> with this?
> >>>>>
> >>>>
> >>>> Looking at the source [0] it uses a default pid lock file path, if I
> had
> >>>> to guess the user running the process isn't able to write to that
> >>>> directory or it does not exist. You can specify an alternate path
> under
> >>>> ircbot.pid in the ini config file if I am reading that correctly.
> >>>>
> >>>> [0]
> >>>>
> >>>>
> >>
> https://git.openstack.org/cgit/openstack-infra/gerritbot/tree/gerritbot/bot.py#n344
> >>>>
> >>>> Hope this helps,
> >>>> Clark
> >>>>
> >>>
> >>>
> >>>
> >>> _______________________________________________
> >>> OpenStack-Infra mailing list
> >>> OpenStack-Infra at lists.openstack.org
> >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
> >>>
> >>
> >>
> >> _______________________________________________
> >> OpenStack-Infra mailing list
> >> OpenStack-Infra at lists.openstack.org
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
> >>
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-infra/attachments/20160301/5cce3d50/attachment-0001.html>