<p dir="ltr">Thanks for the clarification. I'll bring my thoughts to gerrit in that case!</p>
<div class="gmail_quote">On Mar 1, 2016 06:57, "Anita Kuno" <<a href="mailto:anteaya@anteaya.info">anteaya@anteaya.info</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 03/01/2016 09:39 AM, C.J. Collier wrote:<br>
> Hello Anita,<br>
><br>
> You bet. I'll get it in to gerrit shortly. It's not ready to be merged<br>
> quite yet. I just wanted to start a conversation.<br>
<br>
I totally understand. Having a conversation before a patch is merged<br>
makes perfect sense.<br>
<br>
For us, that conversation takes place in gerrit on a patch rather than<br>
on a mailing list in a thread. Gerrit has the option of setting workflow<br>
-1 on a patch so the owner of the patch can indicate the patch is not<br>
ready to be merged.<br>
<br>
When conversations about patches and approaches take place in gerrit,<br>
folks who may not have been present for the beginning of the<br>
conversation are able to see the history of comments on the patch and<br>
can get themselves up to date. Contributors have become very adept at<br>
using gerrit to sort patches and follow a conversation as it is ongoing<br>
for patches in which they are interested.<br>
<br>
For instance here is a conversation that has been going on for 2 weeks<br>
and is on its 10th patchset: <a href="https://review.openstack.org/#/c/282295/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/282295/</a><br>
<br>
Let us know in infra if you have any questions about submitting a<br>
patchset to gerrit.<br>
<br>
Thanks C.J.,<br>
Anita.<br>
<br>
><br>
> For instance, would anyone be opposed to using a syslog sink for logging<br>
> rather than opening up a dedicated file? There are a lot of files (pid,<br>
> log, config, channel list) being handled here, and directories for output<br>
> files (/var/run/gerritbot, /var/log/gerritbot) need to be managed by the<br>
> init script and kept in sync with the values in the config files. Fewer is<br>
> better in my opinion, and hooking in to the syslog infrastructure means<br>
> getting remote logging for no additional cost. However, for systems<br>
> without syslog facilities, I guess it make sense to have a dedicated log<br>
> file.<br>
><br>
> Let me know what you think,<br>
><br>
> C.J.<br>
> On Mar 1, 2016 00:16, "Anita Kuno" <<a href="mailto:anteaya@anteaya.info">anteaya@anteaya.info</a>> wrote:<br>
><br>
>> On 03/01/2016 01:22 AM, C.J. Collier wrote:<br>
>>> Thanks Clark! I found the same thing. I've added a few of options and a<br>
>>> dependency on the getopt library. Take a look at this patch and let me<br>
>>> know if there's anything you'd like me to add / remove.<br>
>>><br>
>>> Cheers,<br>
>>><br>
>>> C.J.<br>
>><br>
>> Thanks for the patch, C.J.<br>
>><br>
>> We put all our patches up in gerrit for review rather than attaching<br>
>> diffs to emails, it is just our workflow.<br>
>><br>
>> You might find <a href="http://docs.openstack.org/infra/manual/developers.html" rel="noreferrer" target="_blank">http://docs.openstack.org/infra/manual/developers.html</a><br>
>> interesting as it outlines our workflow including steps to get all the<br>
>> account signups in order so you can submit a patch to gerrit.<br>
>><br>
>> Thanks for your interest in gerritbot, C.J. We appreciate it.<br>
>><br>
>> Anita.<br>
>><br>
>>><br>
>>><br>
>>> On Mon, Feb 29, 2016 at 6:47 PM, Clark Boylan <<a href="mailto:cboylan@sapwetik.org">cboylan@sapwetik.org</a>><br>
>> wrote:<br>
>>><br>
>>>> On Mon, Feb 29, 2016, at 01:26 PM, C.J. Collier wrote:<br>
>>>>> Hey folks,<br>
>>>>><br>
>>>>> I'm having a heck of a time getting gerritbot working. It currently<br>
>>>>> exits<br>
>>>>> prematurely without any console output and returns 0 to the calling<br>
>>>>> process. No entries in the logs. Very frustrating. Can I get some<br>
>> help<br>
>>>>> with this?<br>
>>>>><br>
>>>><br>
>>>> Looking at the source [0] it uses a default pid lock file path, if I had<br>
>>>> to guess the user running the process isn't able to write to that<br>
>>>> directory or it does not exist. You can specify an alternate path under<br>
>>>> ircbot.pid in the ini config file if I am reading that correctly.<br>
>>>><br>
>>>> [0]<br>
>>>><br>
>>>><br>
>> <a href="https://git.openstack.org/cgit/openstack-infra/gerritbot/tree/gerritbot/bot.py#n344" rel="noreferrer" target="_blank">https://git.openstack.org/cgit/openstack-infra/gerritbot/tree/gerritbot/bot.py#n344</a><br>
>>>><br>
>>>> Hope this helps,<br>
>>>> Clark<br>
>>>><br>
>>><br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> OpenStack-Infra mailing list<br>
>>> <a href="mailto:OpenStack-Infra@lists.openstack.org">OpenStack-Infra@lists.openstack.org</a><br>
>>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra</a><br>
>>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> OpenStack-Infra mailing list<br>
>> <a href="mailto:OpenStack-Infra@lists.openstack.org">OpenStack-Infra@lists.openstack.org</a><br>
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra</a><br>
>><br>
><br>
<br>
</blockquote></div>