Open Stack

Hello Anita,

You bet.  I'll get it in to gerrit shortly.  It's not ready to be merged
quite yet.  I just wanted to start a conversation.

For instance, would anyone be opposed to using a syslog sink for logging
rather than opening up a dedicated file?  There are a lot of files (pid,
log, config, channel list) being handled here, and directories for output
files (/var/run/gerritbot, /var/log/gerritbot) need to be managed by the
init script and kept in sync with the values in the config files.  Fewer is
better in my opinion, and hooking in to the syslog infrastructure means
getting remote logging for no additional cost.  However, for systems
without syslog facilities, I guess it make sense to have a dedicated log
file.

Let me know what you think,

C.J.
On Mar 1, 2016 00:16, "Anita Kuno" <anteaya at anteaya.info> wrote:

> On 03/01/2016 01:22 AM, C.J. Collier wrote:
> > Thanks Clark!  I found the same thing.  I've added a few of options and a
> > dependency on the getopt library.  Take a look at this patch and let me
> > know if there's anything you'd like me to add / remove.
> >
> > Cheers,
> >
> > C.J.
>
> Thanks for the patch, C.J.
>
> We put all our patches up in gerrit for review rather than attaching
> diffs to emails, it is just our workflow.
>
> You might find http://docs.openstack.org/infra/manual/developers.html
> interesting as it outlines our workflow including steps to get all the
> account signups in order so you can submit a patch to gerrit.
>
> Thanks for your interest in gerritbot, C.J. We appreciate it.
>
> Anita.
>
> >
> >
> > On Mon, Feb 29, 2016 at 6:47 PM, Clark Boylan <cboylan at sapwetik.org>
> wrote:
> >
> >> On Mon, Feb 29, 2016, at 01:26 PM, C.J. Collier wrote:
> >>> Hey folks,
> >>>
> >>> I'm having a heck of a time getting gerritbot working.  It currently
> >>> exits
> >>> prematurely without any console output and returns 0 to the calling
> >>> process.  No entries in the logs.  Very frustrating.  Can I get some
> help
> >>> with this?
> >>>
> >>
> >> Looking at the source [0] it uses a default pid lock file path, if I had
> >> to guess the user running the process isn't able to write to that
> >> directory or it does not exist. You can specify an alternate path under
> >> ircbot.pid in the ini config file if I am reading that correctly.
> >>
> >> [0]
> >>
> >>
> https://git.openstack.org/cgit/openstack-infra/gerritbot/tree/gerritbot/bot.py#n344
> >>
> >> Hope this helps,
> >> Clark
> >>
> >
> >
> >
> > _______________________________________________
> > OpenStack-Infra mailing list
> > OpenStack-Infra at lists.openstack.org
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
> >
>
>
> _______________________________________________
> OpenStack-Infra mailing list
> OpenStack-Infra at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-infra/attachments/20160301/3eb0bd54/attachment.html>