Open Stack

On Tue, Sep 15, 2015 at 06:09:45PM +0000, Marton Kiss wrote:
> Dear all,
> 
> Actually openstack-infra/system-config is using the
> openstack-infra/puppet-vcsrepo module for handling git repositories.
> 
> With Jeremy and Clark we found an issue related this vcsrepo module which
> is a fork of original puppetlabs-vcsrepo, but not follow the upstream. I
> made a little poc to demonstrate the issue, which is related to the refresh
> event invocation of github repositories.
> 
> https://github.com/mkissam/puppet-vcsrepo-refresh-poc/blob/master/vcsrepo-refresh-poc.md
> 
> The story here, if we checking out a specific commit ref, every puppet run
> will trigger a refresh event, even the repository not changed when we use
> the ensure => latest class parameter.
> 
> The upstream have a patch that resolve this specific issue:
> (MODULES-660) Correct detached HEAD on latest
> https://github.com/puppetlabs/puppetlabs-vcsrepo/commit/6624f40651f44e184878a9fbb862bda886d899e8
> 
> I see to options here: backport the patch from upstream or as an
> alternative, drop openstack-infra/puppet-vcsrepo and use upstream one.
> 
> The question here, what was the exact reason of forking vcsepo? Can we go
> with backport, or freely upgrade the system-config to consume upstream
> vcsrepo?
> 
I think a 3rd option is to remove the dependency on vcsrepo all together.  IIRC,
nibalizer has started the ball rolling on the migration.  A new puppet module,
puppet-git, has been added into our modules for the purpose of replacing
vcsrepo.

I am unsure of the progress, but maybe this issue can help move it along.

[1] https://github.com/nanliu/puppet-git
> Brgds,
>   Marton Kiss

> _______________________________________________
> OpenStack-Infra mailing list
> OpenStack-Infra at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra