[OpenStack-docs] [training-guides] Criteria for core reviewership

Anne Gentle anne at openstack.org
Sat Dec 13 17:11:42 UTC 2014


On Sat, Dec 13, 2014 at 11:05 AM, Roger Luethi <rl at patchworkscience.org>
wrote:
>
> On Sat, 13 Dec 2014 10:54:49 -0600, Anne Gentle wrote:
> > > I agree with all of that. We are considering it, and right now I am
> > > skeptical. So let me rephrase my question: do we expect a 2x +2
> requirement
> > > to provide a net benefit in the forseeable future (Kilo cycle)?
> > >
> > It's a good question, and here's my input. In the early days of docs, we
> > had three of us, and really it was just me merging my own patches. But
> then
> > when we got a few more people, say less than 10, I would still merge
> things
> > for speed as needed, but tried to wait for reviews. As the reviews got
> more
> > valuable, then waiting for the second +2 was really worthwhile. Plus, it
>
> Good to hear this has already been tried under similar circumstances. One
> question: did you vote +2 on your own patches and then wait for another +2,
> or did you post your patches waiting for two core reviewers to give you +2
> each?
>

Oh definitely can +2 your own patches early on and with small teams. I
still do so for API docs. It has only been this last year or so where I've
gotten to the point where I get two others to +2 my patches in
openstack-manuals.


>
> Roger
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-docs/attachments/20141213/1016b4d6/attachment.html>


More information about the OpenStack-docs mailing list