Open Stack

Roger, sometimes there is not an urgent need for improvement but that
does not mean that we stop improving (IMHO). If I recall correctly, we
decided to not have 2 x +2's due to the size of our core-reviewer team.
Now that we will have more core reviewers, it should be considered.

On Fri, Dec 12, 2014 at 11:00 AM, Roger Luethi <rl at patchworkscience.org>
wrote:

> Excellent write-up. Thank you, Pranav.
>
> One note:
> >    - We need to enforce 2 x +2's before merging a patch.
>
> I think this is one of the areas where we are doing a pretty good job
> already, considering the size of our team. IMO, core reviewers have shown
> good judgment so far. Trivial, obviously correct patches (e.g., spelling
> mistakes) are often merged without waiting for a second core reviewer.
> Non-obvious patches have not been merged without feedback from the domain
> experts (who that is depends on the affected parts of the repo). And
> patches are not merged by the person proposing the patch. Do we need to
> improve our merge processes and if so, in what respect?
>
> Roger
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-docs/attachments/20141212/1ff86bcf/attachment.html>