Open Stack

On Wed, 21 Aug 2013 20:25:27 +0200
Andreas Jaeger <aj at suse.com> wrote:
> On 08/21/2013 05:45 PM, Lorin Hochstein wrote:
> > [...]
> > (This one isn't strictly about review policy...)
> > For submitters amending their patch: the updated commit log message
> > shouldn't break down the changes by individual patchset (i.e.,
> > shouldn't put "patch set 2, added foo" in an amended commit
> > message) since only the final commit will be visible in the git
> > history after it's accepted. (This is the policy with the other
> > OpenStack projects, and it's in the wiki *somewhere*, but I wasn't
> > able to find it after a cursory search).
> 
> I'm new to this - and one of the guilty parties. I have used these
> "patch set, added foo" comments to notify what has changed.
> 
> Is there a better practice to inform the reviewer on what was changed
> between patchsets? I find it valuable to hear what has changed. A diff
> between patchsets would be great as well...

I sometimes (especially if its just a minor update to the changeset
like a rebase) just add a review comment to say what has changed. I
think it makes life easier for the reviewers.

Also in addition to the web interface which Anne mentions in another
email, you can also use git-review -m to locally display the diff
between changesets. Mileage may very if there has been rebasing going
on. I also sometimes download the two diffs and then use interdiff.

Chris