Open Stack

On 08/21/2013 05:45 PM, Lorin Hochstein wrote:
> [...]
> (This one isn't strictly about review policy...)
> For submitters amending their patch: the updated commit log message
> shouldn't break down the changes by individual patchset (i.e., shouldn't
> put "patch set 2, added foo" in an amended commit message) since only
> the final commit will be visible in the git history after it's accepted.
> (This is the policy with the other OpenStack projects, and it's in the
> wiki *somewhere*, but I wasn't able to find it after a cursory search).

I'm new to this - and one of the guilty parties. I have used these
"patch set, added foo" comments to notify what has changed.

Is there a better practice to inform the reviewer on what was changed
between patchsets? I find it valuable to hear what has changed. A diff
between patchsets would be great as well...

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126