Open Stack

Hi Christian,
I just saw this change, but am too late to comment as a review.

For the remove_unnecessary_spaces.py script:
There are times when the spaces inside tags are intentional. For 
example, when the space is required, but can be moved outside the tags 
(I hit this one in my last commit). Could you possibly add an option 
that just displays the problems/line numbers instead of fixing them?

examples for remove_unnecessary_spaces.py:

"<testing> foobar foobar" --> "<testing>foobar foobar"
"foobar foobar </testing>" --> "foobar foobar</testing>"


Thanks, Summer


Summer Long
OpenStack Documentation
Engineering Content Services

Red Hat Asia Pacific
Brisbane, Australia
slong at redhat.com <mailto:slong at redhat.com>

On 08/15/2013 07:52 PM, Christian Berendt (Code Review) wrote:
> Christian Berendt has posted comments on this change.
>
> Change subject: Change whitespace check to be info only
> ......................................................................
>
>
> Patch Set 1:
>
> I added two scripts to manually cleanup spaces at https://review.openstack.org/#/c/42092/.
>
> Maybe it's possible to create a job on Jenkins to run those scripts before the commit to automatically cleanup the files.
>
> --
> To view, visit https://review.openstack.org/41623
> To unsubscribe, visit https://review.openstack.org/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I082aa4418864cd50d087dfe01c3bfff4d6df9f8f
> Gerrit-PatchSet: 1
> Gerrit-Project: openstack/openstack-manuals
> Gerrit-Branch: master
> Gerrit-Owner: Tom Fifield <tom at openstack.org>
> Gerrit-Reviewer: Anne Gentle <anne at openstack.org>
> Gerrit-Reviewer: Christian Berendt <berendt at b1-systems.de>
> Gerrit-Reviewer: Jenkins
> Gerrit-Reviewer: Stephen Gordon <sgordon at redhat.com>
> Gerrit-Reviewer: Summer Long <slong at redhat.com>
> Gerrit-Reviewer: Tom Fifield <tom at openstack.org>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-docs/attachments/20130816/3b76552e/attachment-0001.html>