<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Christian, <br>
I just saw this change, but am too late to comment as a review.<br>
<br>
For the remove_unnecessary_spaces.py script: <br>
There are times when the spaces inside tags are intentional. For
example, when the space is required, but can be moved outside the
tags (I hit this one in my last commit). Could you possibly add an
option that just displays the problems/line numbers instead of
fixing them?<br>
<br>
<p style="margin-top: 0px; padding-top: 0.5em; color: rgb(0, 0, 0);
font-family: 'Lucida Console', 'Lucida Sans Typewriter', Monaco,
monospace; font-size: 11px; font-style: normal; font-variant:
normal; font-weight: normal; letter-spacing: normal; line-height:
normal; orphans: auto; text-align: -webkit-left; text-indent: 0px;
text-transform: none; white-space: pre; widows: auto;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-color: rgb(255, 255, 255);">examples for
remove_unnecessary_spaces.py:</p>
<p style="margin-top: 0px; padding-top: 0.5em; color: rgb(0, 0, 0);
font-family: 'Lucida Console', 'Lucida Sans Typewriter', Monaco,
monospace; font-size: 11px; font-style: normal; font-variant:
normal; font-weight: normal; letter-spacing: normal; line-height:
normal; orphans: auto; text-align: -webkit-left; text-indent: 0px;
text-transform: none; white-space: pre; widows: auto;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-color: rgb(255, 255, 255);">"<testing> foobar
foobar" --> "<testing>foobar foobar"<br>
"foobar foobar </testing>" --> "foobar
foobar</testing>"</p>
<br>
Thanks, Summer<br>
<br>
<br>
<div class="moz-signature">
<div><font color="#666666">Summer Long<br>
OpenStack Documentation<br>
Engineering Content Services<br>
<br>
Red Hat Asia Pacific<br>
Brisbane, Australia</font><br>
<a href="mailto:slong@redhat.com">slong@redhat.com</a></div>
</div>
<br>
<span style="color:#000000;" class="headerSpan">
<div class="moz-cite-prefix">On 08/15/2013 07:52 PM, Christian
Berendt (Code Review) wrote:<br>
</div>
</span>
<blockquote cite="mid:E1V9uEW-0005VZ-Ae@review.openstack.org"
type="cite">
<pre wrap="">Christian Berendt has posted comments on this change.
Change subject: Change whitespace check to be info only
......................................................................
Patch Set 1:
I added two scripts to manually cleanup spaces at <a class="moz-txt-link-freetext" href="https://review.openstack.org/#/c/42092/">https://review.openstack.org/#/c/42092/</a>.
Maybe it's possible to create a job on Jenkins to run those scripts before the commit to automatically cleanup the files.
--
To view, visit <a class="moz-txt-link-freetext" href="https://review.openstack.org/41623">https://review.openstack.org/41623</a>
To unsubscribe, visit <a class="moz-txt-link-freetext" href="https://review.openstack.org/settings">https://review.openstack.org/settings</a>
Gerrit-MessageType: comment
Gerrit-Change-Id: I082aa4418864cd50d087dfe01c3bfff4d6df9f8f
Gerrit-PatchSet: 1
Gerrit-Project: openstack/openstack-manuals
Gerrit-Branch: master
Gerrit-Owner: Tom Fifield <a class="moz-txt-link-rfc2396E" href="mailto:tom@openstack.org"><tom@openstack.org></a>
Gerrit-Reviewer: Anne Gentle <a class="moz-txt-link-rfc2396E" href="mailto:anne@openstack.org"><anne@openstack.org></a>
Gerrit-Reviewer: Christian Berendt <a class="moz-txt-link-rfc2396E" href="mailto:berendt@b1-systems.de"><berendt@b1-systems.de></a>
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Stephen Gordon <a class="moz-txt-link-rfc2396E" href="mailto:sgordon@redhat.com"><sgordon@redhat.com></a>
Gerrit-Reviewer: Summer Long <a class="moz-txt-link-rfc2396E" href="mailto:slong@redhat.com"><slong@redhat.com></a>
Gerrit-Reviewer: Tom Fifield <a class="moz-txt-link-rfc2396E" href="mailto:tom@openstack.org"><tom@openstack.org></a>
</pre>
</blockquote>
<br>
</body>
</html>