[all][tc] Lets talk about Flake8 E501

Miro Tomaska mtomaska at redhat.com
Sat May 28 02:24:32 UTC 2022

Hello All,

This is probably going to be a hot topic but I was wondering if the
community ever considered raising the default 79 characters line limit. I
have seen some places where even a very innocent line of code needs to be
split into two lines. I have also seen some code where I feel like variable
names were abbreviated on purpose to squeeze everything into one line.

How does the community feel about raising the E501 limit to 119 characters?
The 119 character limit is the second most popular limit besides the
default one. It's long enough to give a developer enough room for
descriptive variables without being forced to break lines too much. And it
is short enough for a diff between two files to look OK.

The only downside I can see right now is that it's not easy to convert an
existing code. So we will end up with files where the new code is 79+
characters and the "old" code is <=79. I can also see an argument where
someone might have trouble reviewing a patch on a laptop screen (assuming
standard 14" screen) ?

Here is an example of one extreme, a diff of two files maxing out at 119


Thank you for your time and I am looking forward to this conversation :)

Miro Tomaska
irc: mtomaska
Red Hat
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-discuss/attachments/20220527/12138e2b/attachment-0001.htm>

More information about the openstack-discuss mailing list