Open Stack

Arx,

First of all I want to repeat that it has nothing to do with the quality of
your work. Again, I'm aware of what you've been working on and I appreciate
what you have been doing with the CI team.

The major issue that I'm dealing with as a major maintainer of TripleO is
that over the past years we have promoted a lot of people to be core
reviewers; but if you closely look at numbers: most of the reviews are done
by 3 people; this is problematic when one of us is absent; and even more
problematic if one of us one day leave.

I have the feeling that promoting more core developers hasn't solved that
problem; and there are few folks currently core that should not be core
anymore IMO; because they don't review much and aren't much involved as
"core maintainers".
Being a core reviewer means you're an official maintainer. You maintain the
code, wherever it is; if it's something that your direct peer wrote or
something that $random_contributor wrote. Very often we have promoted cores
who only review things from their direct peers and this has been
problematic because 1) reviews are done by silos and 2) some parts of the
project aren't reviewed at all. It has nothing to do with you but just to
give you a bit of context on why I'm being more conservative now.

You said that you have spent major time on things not under TripleO
umbrella: please know that I'm aware of this, I'm watching it and I
appreciate it. However we are talking about TripleO CI core which is under
TripleO umbrella. Not Podman, not RDO CI etc. Which is why I went looking
to Stackalytics to see numbers (even if I take them with a grain of salt).

The core promotion is a decision that is taken as a group. My -1 doesn't
mean you won't be core, it just means I had to provide some feedback on why
I'm reluctant of you being core as of now. It doesn't mean I don't find
your work valuable or that you're not helping on IRC; actually you're doing
great. I just think that the bar is a bit higher compared to my taste and I
don't think you're far from reaching it.

Now, this is only my opinion and what it's worth. My hope is that 1) you
continue to improve your involvement in TripleO and 2) our core reviewers
do more reviews because it can't only be 3 persons who do more than 70% of
the reviews.

Have a great weekend,
Emilien

On Sat, Jan 11, 2020 at 9:39 AM Arx Cruz <arxcruz at redhat.com> wrote:

> Hello Emilien,
>
> Thanks for your feedback, I really appreciate it.
> You are right, there are places that I really can improve, and I will work
> to improve it, and I really looking forward to have your help.
>
> Regarding the amount of reviews and commits, it’s true that I haven’t be
> so active on tripleo upstream projects, but please, remember that
> stackalytics only reflect the projects under tripleo umbrella, and you know
> that in tripleo-ci we also work on rdo side, where I’ve been working more
> activelly, right now, working on integration with thirdy party projects
> like podman and ceph-ansible, which is not directly related to Tripleo
> indeed, but are key projects to Tripleo work properly.
>
> Also, look only in the latest release patches doesn’t seems to be too
> fair, if you check the previous release I have more than double of reviews
> (although yes, the number of commits remains stable), and probably if you
> get the Ussuri release, I will not have too much reviews or commits, since
> I’ve been on vacation mostly of the december.
>
> Also, and please, correct me if I am wrong, I don’t remember anytime that
> people ping me on IRC and I did not reply, or was prompt to help, if that
> happens, please accept my sincere apologies, as you know, when things are
> on fire (long time without promotions for example, like the last sprint I
> was ruck and rover) our focus is to make things get back to normal.
>
> One more time, I am taking your feedback, and I’ll do my best to improve
> in the areas you point, and hopefully change your mind regarding my core
> promotion.
>
> Kind regards,
> Arx Cruz
>
> On Fri, 10 Jan 2020 at 16:45 Emilien Macchi <emilien at redhat.com> wrote:
>
>> +1 for Chandan; no doubt; he's always available on IRC to help when
>> things go wrong in gate or promotion, and very often he's proposing the fix.
>> Providing thoroughful reviews, and multi-project contributors, I've seen
>> Chandan involved not only in TripleO CI but also in other projects like RDO
>> and TripleO itself. I've seen him contributing to the tripleo-common and
>> tripleoclient projects; which make him someone capable to understand not
>> only how CI works but also how the project in general works. Having him
>> core is to me natural.
>>
>> Number of commits/reviews shows his interests in the CI repos:
>>
>> https://www.stackalytics.com/?user_id=chandankumar-093047&release=train&metric=marks
>>
>> https://www.stackalytics.com/?user_id=chandankumar-093047&release=train&metric=commits
>>
>> ----
>>
>> I hate playing devil's advocate here but I'll give my honest (and
>> hopefully constructive) opinion.
>> I would like to see more involvement from Arx in the TripleO community.
>> He did a tremendous work on openstack-ansible-os_tempest; however this repo
>> isn't governed by TripleO CI group. I would like to see more reviews; where
>> he can bring his expertise; and not only in Gerrit but also on IRC when
>> things aren't going well (gate issues, promotion blockers, etc).
>>
>> Number of commits/reviews aren't low but IMHO can be better for a core
>> reviewer.
>> https://www.stackalytics.com/?user_id=arxcruz&release=train&metric=commits
>> https://www.stackalytics.com/?user_id=arxcruz&release=train&metric=marks
>>
>> I don't think it'll take time until Arx gets there but to me it's a -1
>> for now, for what it's worth.
>>
>> Emilien
>>
>> On Fri, Jan 10, 2020 at 9:20 AM Ronelle Landy <rlandy at redhat.com> wrote:
>>
>>> Hello All,
>>>
>>> I'd like to propose Arx Cruz (arxcruz at redhat.com) and Chandan Kumar (
>>> chkumar at redhat.com) as core on tripleo-ci repos (tripleo-ci,
>>> tripleo-quickstart, tripleo-quickstart-extras).
>>>
>>> In addition to the extensive work that Arx and Chandan have done on the
>>> Tempest-related repos ( and Tempest interface/settings within the Tripleo
>>> CI repos) , they have become active contributors to the core Tripleo CI
>>> repos, in general, in the past two years.
>>>
>>> Please vote by replying to this thread with +1 or -1 for any objections.
>>> We will close the vote 7 days from now.
>>>
>>> Thank you,
>>> Ronelle
>>>
>>
>>
>> --
>> Emilien Macchi
>>
> --
>
> Arx Cruz
>
> Software Engineer
>
> Red Hat EMEA <https://www.redhat.com>
>
> arxcruz at redhat.com
> @RedHat <https://twitter.com/redhat>   Red Hat
> <https://www.linkedin.com/company/red-hat>  Red Hat
> <https://www.facebook.com/RedHatInc>
> <https://www.redhat.com>
>


-- 
Emilien Macchi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-discuss/attachments/20200111/c5a964fb/attachment-0001.html>