I can help on it. 2018-05-31 21:49 GMT+08:00 Eric Fried <openstack at fried.cc>: > Yup. I'm sure reviewers will bikeshed the names, but the review is the > appropriate place for that to happen. > > A couple of test changes will also be required. You can have a look at > [1] as an example to follow. > > -efried > > [1] https://review.openstack.org/#/c/511180/ > > On 05/31/2018 01:02 AM, Nadathur, Sundar wrote: > > On 5/30/2018 1:18 PM, Eric Fried wrote: > >> This all sounds fully reasonable to me. One thing, though... > >> > >>>> * There is a resource class per device category e.g. > >>>> CUSTOM_ACCELERATOR_GPU, CUSTOM_ACCELERATOR_FPGA. > >> Let's propose standard resource classes for these ASAP. > >> > >> https://github.com/openstack/nova/blob/d741f624c81baf89fc8b6b94a2bc20 > eb5355a818/nova/rc_fields.py > >> > >> > >> -efried > > Makes sense, Eric. The obvious names would be ACCELERATOR_GPU and > > ACCELERATOR_FPGA. Do we just submit a patch to rc_fields.py? > > > > Thanks, > > Sundar > > > > ____________________________________________________________ > ______________ > > OpenStack Development Mailing List (not for usage questions) > > Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject: > unsubscribe > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20180601/69930c1c/attachment.html>