<div dir="ltr">I can help on it.<br><div class="gmail_extra"><br><div class="gmail_quote">2018-05-31 21:49 GMT+08:00 Eric Fried <span dir="ltr"><<a href="mailto:openstack@fried.cc" target="_blank">openstack@fried.cc</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yup.  I'm sure reviewers will bikeshed the names, but the review is the<br>
appropriate place for that to happen.<br>
<br>
A couple of test changes will also be required.  You can have a look at<br>
[1] as an example to follow.<br>
<br>
-efried<br>
<br>
[1] <a href="https://review.openstack.org/#/c/511180/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/511180/</a><br>
<div class="HOEnZb"><div class="h5"><br>
On 05/31/2018 01:02 AM, Nadathur, Sundar wrote:<br>
> On 5/30/2018 1:18 PM, Eric Fried wrote:<br>
>> This all sounds fully reasonable to me.  One thing, though...<br>
>><br>
>>>>        * There is a resource class per device category e.g.<br>
>>>>          CUSTOM_ACCELERATOR_GPU, CUSTOM_ACCELERATOR_FPGA.<br>
>> Let's propose standard resource classes for these ASAP.<br>
>><br>
>> <a href="https://github.com/openstack/nova/blob/d741f624c81baf89fc8b6b94a2bc20eb5355a818/nova/rc_fields.py" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>nova/blob/<wbr>d741f624c81baf89fc8b6b94a2bc20<wbr>eb5355a818/nova/rc_fields.py</a><br>
>><br>
>><br>
>> -efried<br>
> Makes sense, Eric. The obvious names would be ACCELERATOR_GPU and<br>
> ACCELERATOR_FPGA. Do we just submit a patch to rc_fields.py?<br>
> <br>
> Thanks,<br>
> Sundar<br>
> <br>
> ______________________________<wbr>______________________________<wbr>______________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
</div></div></blockquote></div><br></div></div>