Open Stack

On Tue, Jul 18, 2017 at 8:24 AM, Matt Riedemann <mriedemos at gmail.com> wrote:
> I don't have a strict recreate on this right now, but wanted to bring it up
> in case others have seen it. I've done this unknowingly and seen it happen
> to other changes, like:
>
> https://review.openstack.org/#/c/428241/7..8//COMMIT_MSG
>
> https://review.openstack.org/#/c/327564/3..4//COMMIT_MSG
>
> Where the author changes in the commit.
>
> When I've seen this, I think it's because I'm doing some combination of:
>
> 1. git review -d
> 2. git rebase -i master
> 3. change something
> 4. git commit

Yes, this is same case when we do fetch patch set using git checkout,
i do not think its something to do with gite review -d. I usually do
mention author explicitly during git commit to keep the original
author.
git commit --author <....>

> 5. git rebase --continue (if in the middle of a series)
> 6. git review
>
> Something about the combination of the git review/rebase/commit changes the
> author.
>
> Again, I can try to recreate and come up with repeatable steps later, but
> wanted to bring this up while I'm thinking about it again.
>
> My versions:
>
> user at ubuntu:~/git/nova$ git --version
> git version 2.7.4
> user at ubuntu:~/git/nova$ pip show git-review
> Name: git-review
> Version: 1.25.0
>
>
> --
>
> Thanks,
>
> Matt
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev