[openstack-dev] [cinder] [nova] confusion on where nova_catalog_admin_info is used in cinder

Duncan Thomas duncan.thomas at gmail.com
Tue Feb 14 13:48:58 UTC 2017


This is only used by the file based drivers, who need to call nova for
assistance with attached snapshots. Most drivers won't use it, including
the default, LVM.

I can't comment on the test coverage, sorry.

On 14 February 2017 at 13:01, Sean Dague <sean at dague.net> wrote:

> After some of the confusion around endpoints in devstack, we decided to
> simplify the endpoints registered in devstack to only the ones needed
> for development. Basically only register "public" interfaces unless
> there is something special about the service.
>
> https://review.openstack.org/#/c/433272/ is the change.
>
> Matt Riedemann pointed out that this would break Cinder because there is
> a hardcoded concept of nova_catalog_admin_info -
> https://github.com/openstack/cinder/blob/cfc617b0cea99ed6994f08e5337fd5
> b65ea9fd1c/cinder/compute/nova.py#L39-L41
>
> Except... it didn't (see results on
> https://review.openstack.org/#/c/433272/).
>
> What is more confusing, is the oslo.config dump at the beginning of
> cinder service starts there don't have any reference to any of these
> nova_ config variables.
>
> How is this code loaded and used? Is there no testing of cinder -> nova
> happening in the gate? Is this missing testing, or are there reasons
> these configurations would never load that code?
>
>         -Sean
>
> --
> Sean Dague
> http://dague.net
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
-- 
Duncan Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20170214/09d921d6/attachment.html>


More information about the OpenStack-dev mailing list