<div dir="ltr"><div>This is only used by the file based drivers, who need to call nova for assistance with attached snapshots. Most drivers won't use it, including the default, LVM.<br><br></div>I can't comment on the test coverage, sorry.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 14 February 2017 at 13:01, Sean Dague <span dir="ltr"><<a href="mailto:sean@dague.net" target="_blank">sean@dague.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">After some of the confusion around endpoints in devstack, we decided to<br>
simplify the endpoints registered in devstack to only the ones needed<br>
for development. Basically only register "public" interfaces unless<br>
there is something special about the service.<br>
<br>
<a href="https://review.openstack.org/#/c/433272/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/433272/</a> is the change.<br>
<br>
Matt Riedemann pointed out that this would break Cinder because there is<br>
a hardcoded concept of nova_catalog_admin_info -<br>
<a href="https://github.com/openstack/cinder/blob/cfc617b0cea99ed6994f08e5337fd5b65ea9fd1c/cinder/compute/nova.py#L39-L41" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>cinder/blob/<wbr>cfc617b0cea99ed6994f08e5337fd5<wbr>b65ea9fd1c/cinder/compute/<wbr>nova.py#L39-L41</a><br>
<br>
Except... it didn't (see results on<br>
<a href="https://review.openstack.org/#/c/433272/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/433272/</a>).<br>
<br>
What is more confusing, is the oslo.config dump at the beginning of<br>
cinder service starts there don't have any reference to any of these<br>
nova_ config variables.<br>
<br>
How is this code loaded and used? Is there no testing of cinder -> nova<br>
happening in the gate? Is this missing testing, or are there reasons<br>
these configurations would never load that code?<br>
<span class="HOEnZb"><font color="#888888"><br>
        -Sean<br>
<br>
--<br>
Sean Dague<br>
<a href="http://dague.net" rel="noreferrer" target="_blank">http://dague.net</a><br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>-- <br>Duncan Thomas</div></div></div>
</div>