Open Stack

I also thought that my second proposal is the more reasonable one, calling the get_all in the AodhDriver contructor.

Looking forward to see the updated code, and push it upstream ☺

From: Yujun Zhang [mailto:zhangyujun+zte at gmail.com]
Sent: Monday, November 28, 2016 8:10 AM
To: dong.wenjuan at zte.com.cn
Cc: OpenStack Development Mailing List (not for usage questions); Hefetz, Idan (Nokia - IL); zhang.yujunz at zte.com.cn
Subject: [ALU] Re: [openstack-dev] [vitrage] about aodh alarm notification

Agree.

It seems I missed the first clause in Alexeys 2nd proposal. `get_all` in constructor could be a good solution.

On Mon, Nov 28, 2016 at 12:18 PM <dong.wenjuan at zte.com.cn<mailto:dong.wenjuan at zte.com.cn>> wrote:


Hi all,

Maybe call the get_all method in the AodhDriver constructor and cache all the alarms is a simple way.

BR,
dwj


Yujun Zhang <zhangyujun+zte at gmail.com<mailto:zhangyujun%2Bzte at gmail.com>>

2016-11-28 11:23

收件人

"OpenStack Development Mailing List (not for usage questions)" <openstack-dev at lists.openstack.org<mailto:openstack-dev at lists.openstack.org>>, "dong.wenjuan at zte.com.cn<mailto:dong.wenjuan at zte.com.cn>" <dong.wenjuan at zte.com.cn<mailto:dong.wenjuan at zte.com.cn>>

抄送

"Hefetz, Idan (Nokia - IL)" <idan.hefetz at nokia.com<mailto:idan.hefetz at nokia.com>>, "zhang.yujunz at zte.com.cn<mailto:zhang.yujunz at zte.com.cn>" <zhang.yujunz at zte.com.cn<mailto:zhang.yujunz at zte.com.cn>>

主题

Re: [openstack-dev] [vitrage] about aodh alarm notification







Hi, Alexey

My comments inline.

On Mon, Nov 28, 2016 at 1:52 AM Weyl, Alexey (Nokia - IL) <alexey.weyl at nokia.com<mailto:alexey.weyl at nokia.com>> wrote:
Hi Dong,



I can think of 2 solutions for this problem:

1.       We can talk with the AODH developers and check if they can add additional data for the aodh notifications.

I think it might not be easily accepted since sending only the changes on update notification looks more reasonable to me.
2.       We can add a cache in the aodh driver, and call the get_all method in the AodhDriver constructor or when the first notification happens and fill the cache with the data. Then for each notification that arrives you  will update that cache in the aodh notification service, and send then event with all the data you need.

I doubt this will degrade the performance for the first notification since there will be additional conversation to retrieve the full data.

My proposal is to share a cache between snapshot service and listener service and I think it is a common requirements for all datasource using PUSH method.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20161128/f736b236/attachment.html>