<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"MS Gothic";
panose-1:2 11 6 9 7 2 5 8 2 4;}
@font-face
{font-family:MingLiU;
panose-1:2 2 5 9 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"\@MingLiU";
panose-1:2 2 5 9 0 0 0 0 0 0;}
@font-face
{font-family:"\@MS Gothic";
panose-1:2 11 6 9 7 2 5 8 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
p.gmailmsg, li.gmailmsg, div.gmailmsg
{mso-style-name:gmail_msg;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I also thought that my second proposal is the more reasonable one, calling the get_all in the AodhDriver contructor.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Looking forward to see the updated code, and push it upstream
</span><span style="font-size:11.0pt;font-family:Wingdings;color:#1F497D">J</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Yujun Zhang [mailto:zhangyujun+zte@gmail.com]
<br>
<b>Sent:</b> Monday, November 28, 2016 8:10 AM<br>
<b>To:</b> dong.wenjuan@zte.com.cn<br>
<b>Cc:</b> OpenStack Development Mailing List (not for usage questions); Hefetz, Idan (Nokia - IL); zhang.yujunz@zte.com.cn<br>
<b>Subject:</b> [ALU] Re: [openstack-dev] [vitrage] about aodh alarm notification<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">Agree.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">It seems I missed the first clause in Alexeys 2nd proposal. `get_all` in constructor could be a good solution.<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Mon, Nov 28, 2016 at 12:18 PM <<a href="mailto:dong.wenjuan@zte.com.cn" target="_blank">dong.wenjuan@zte.com.cn</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
<span style="font-size:10.0pt;font-family:"Arial","sans-serif""><br>
</span>Hi all, <br>
<br>
Maybe call the get_all method in the AodhDriver constructor and cache all the alarms is a simple way.<br>
<br>
BR, <br>
dwj <br>
<br>
<br>
<o:p></o:p></p>
<table class="MsoNormalTable" border="0" cellpadding="0" width="100%" style="width:100.0%">
<tbody>
<tr>
<td width="36%" valign="top" style="width:36.0%;padding:.75pt .75pt .75pt .75pt">
<p class="MsoNormal"><b><span style="font-size:7.5pt;font-family:"Arial","sans-serif"">Yujun Zhang <<a href="mailto:zhangyujun%2Bzte@gmail.com" target="_blank">zhangyujun+zte@gmail.com</a>></span></b><span style="font-size:7.5pt;font-family:"Arial","sans-serif"">
</span><o:p></o:p></p>
<p class="gmailmsg"><span style="font-size:7.5pt;font-family:"Arial","sans-serif"">2016-11-28 11:23</span>
<o:p></o:p></p>
</td>
<td width="63%" valign="top" style="width:63.0%;padding:.75pt .75pt .75pt .75pt">
<table class="MsoNormalTable" border="0" cellpadding="0" width="100%" style="width:100.0%">
<tbody>
<tr>
<td valign="top" style="padding:.75pt .75pt .75pt .75pt">
<p class="MsoNormal" align="right" style="text-align:right"><span style="font-size:7.5pt;font-family:"MS Gothic"">收件人</span><o:p></o:p></p>
</td>
<td valign="top" style="padding:.75pt .75pt .75pt .75pt">
<p class="MsoNormal"><span style="font-size:7.5pt;font-family:"Arial","sans-serif"">"OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>>, "<a href="mailto:dong.wenjuan@zte.com.cn" target="_blank">dong.wenjuan@zte.com.cn</a>"
<<a href="mailto:dong.wenjuan@zte.com.cn" target="_blank">dong.wenjuan@zte.com.cn</a>></span>
<o:p></o:p></p>
</td>
</tr>
<tr>
<td valign="top" style="padding:.75pt .75pt .75pt .75pt">
<p class="MsoNormal" align="right" style="text-align:right"><span style="font-size:7.5pt;font-family:"MS Gothic"">抄送</span><o:p></o:p></p>
</td>
<td valign="top" style="padding:.75pt .75pt .75pt .75pt">
<p class="MsoNormal"><span style="font-size:7.5pt;font-family:"Arial","sans-serif"">"Hefetz, Idan (Nokia - IL)" <<a href="mailto:idan.hefetz@nokia.com" target="_blank">idan.hefetz@nokia.com</a>>, "<a href="mailto:zhang.yujunz@zte.com.cn" target="_blank">zhang.yujunz@zte.com.cn</a>"
<<a href="mailto:zhang.yujunz@zte.com.cn" target="_blank">zhang.yujunz@zte.com.cn</a>></span>
<o:p></o:p></p>
</td>
</tr>
<tr>
<td valign="top" style="padding:.75pt .75pt .75pt .75pt">
<p class="MsoNormal" align="right" style="text-align:right"><span style="font-size:7.5pt;font-family:"MS Gothic"">主</span><span style="font-size:7.5pt;font-family:MingLiU">题</span><o:p></o:p></p>
</td>
<td valign="top" style="padding:.75pt .75pt .75pt .75pt">
<p class="MsoNormal"><span style="font-size:7.5pt;font-family:"Arial","sans-serif"">Re: [openstack-dev] [vitrage] about aodh alarm notification</span><o:p></o:p></p>
</td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><o:p> </o:p></p>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td valign="top" style="padding:.75pt .75pt .75pt .75pt"></td>
<td valign="top" style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><br>
<br>
<br>
Hi, Alexey <br>
<br>
My comments inline.<br>
<br>
On Mon, Nov 28, 2016 at 1:52 AM Weyl, Alexey (Nokia - IL) <<a href="mailto:alexey.weyl@nokia.com" target="_blank">alexey.weyl@nokia.com</a>> wrote:
<br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi Dong,</span>
<o:p></o:p></p>
<p class="gmailmsg"><span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span>
<o:p></o:p></p>
<p class="gmailmsg"><span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I can think of 2 solutions for this problem:</span>
<o:p></o:p></p>
<p class="gmailmsg"><span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:#1F497D">1. We can talk with the AODH developers and check if they can add additional data for the aodh notifications.</span>
<o:p></o:p></p>
<p class="gmailmsg">I think it might not be easily accepted since sending only the changes on update notification looks more reasonable to me.
<br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:#1F497D">2. We can add a cache in the aodh driver, and call the get_all method in the AodhDriver constructor or when the first notification happens and fill the cache with the data.
Then for each notification that arrives you will update that cache in the aodh notification service, and send then event with all the data you need.</span>
<o:p></o:p></p>
<p class="gmailmsg">I doubt this will degrade the performance for the first notification since there will be additional conversation to retrieve the full data.
<br>
<br>
My proposal is to share a cache between snapshot service and listener service and I think it is a common requirements for all datasource using PUSH method.
<o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</div>
</body>
</html>