Open Stack

On Tue, Dec 22, 2015 at 4:51 PM, Carl Baldwin <carl at ecbaldwin.net> wrote:
> I noticed another thing.  I'm working with a chain of three patches.
> I just updated the patch in the middle [1] to patch set 37.  I noticed
> that the list of "Related Changes" (in the upper right of the page)
> didn't look right.  The change above it in the list (the one that
> depends it) looked strange.  Looking closer, I realized that the
> dependent patch was linking to patch set 4 [2] which is really old.
> Go here [1] and take a look.
>
> The latest patch set in 212669 (24) depends on a slightly out of date
> version of 192032 (36 of 37).  So, gerrit decides to navigate me to
> version 4 of 212669?  Seems arbitrary to me.  Why doesn't it navigate
> me to the latest version of 212669?  That would be much more useful.

I believe what Gerrit is doing is linking to the PS that was based off
of the one you are currently on.  You can see this by checking the
parent and next commit SHA.  So it looks like 212669/4 is based on
192032/10 therefore I'm guessing that you were actually looking at
192032/10 when you clicked on the link.  I'm not sure that Gerrit took
you to the wrong PS I'm guessing that you were on a newer 212669 PS
than you thought?   I find this disorienting as well and always have
to remind myself to look at the "Patch Sets" indicator to get on the
right page.

>
> Over the last few days, this "Related Changes" table has confused me.
> This is the first time I took the time to pinpoint why it is confusing
> me.
>
> Carl
>
> PS  I'm trying to document these issues in this thread so that they
> don't get lost.  I suppose at some point we need to be feeding this
> stuff up to gerrit.  I was hoping to get other stuff done before
> vacation and so I'm hesitant to stop what I'm doing and shift my
> thinking toward filling out bug reports against gerrit.  What should
> we do?  Should we individually go file bugs against gerrit?  Or,
> should we funnel it through someone working on gerrit in openstack?

Thanks for keeping the openstack infra team updated about issues
you're having with Gerrit, it's good feedback and will help improve
Gerrit going forward.  Unless it's something that requires immediate
attention I would recommend entering a bug/feature request yourself on
upstream Gerrit issue tracker. You can CC me on the issues and I will
try to determine whether it's openstack specific or a general upstream
issue.

>
> [1] https://review.openstack.org/#/c/192032/37
> [2] https://review.openstack.org/#/c/212669/4
>