[openstack-dev] [gantt] Sync up patches
Sylvain Bauza
sylvain.bauza at gmail.com
Tue Jan 14 22:47:38 UTC 2014
Thanks Don for raising the point, I was about to send an email after
finishing up to review.
To me, it appears I have to give -1 when either :
1. Change is related to API documentation or WSGI framework. AIUI, Gantt
will be plugged to Nova thanks to its RPC interface, it makes no sense to
ship any API-related thing then.
2. Gantt is importing Oslo libs from Nova. IMHO, it's error-prone as we
don't manage Olso updates in the Gantt code
3. Gantt is directly using Nova libs.
As per you said, I'm OK for not taking account of 3., provided there is a
clear moment on when we begin to diverge code, but then we need to add nova
trunk as dependency in gantt's requirements.txt
-Sylvain
(I'm in EU timezone, will have to leave in a few)
2014/1/14 Dugger, Donald D <donald.d.dugger at intel.com>
> All-
>
>
>
> I want to clear up some confusion I’m seeing in the reviews of these
> syncup patches. These patches merely bring recent changes from the nova
> tree over to the gantt tree. There is no attempt to actually change the
> code for gantt, that is a separate task. Our first goal is to have the
> scheduler in gantt do exactly what the scheduler in nova does. We want to
> be able to reliably change nova to use the gantt source tree as a drop in
> replacement, get that working before we start making gantt specific changes.
>
>
>
> The gantt tree probably has extra code that can be trimmed out later but,
> as long as that code exists in gantt I want to make it a synced up copy of
> the code in nova.
>
>
>
> --
>
> Don Dugger
>
> "Censeo Toto nos in Kansa esse decisse." - D. Gale
>
> Ph: 303/443-3786
>
>
>
> *From:* Dugger, Donald D
> *Sent:* Tuesday, January 14, 2014 2:48 PM
> *To:* OpenStack Development Mailing List (not for usage questions)
> *Subject:* [gantt] Sync up patches
>
>
>
> All-
>
>
>
> As threatened, I’ve pushed 24 patches to sync up the gantt tree to recent
> changes to the nova tree. They’re all linked in a dependency chain
> starting at:
>
>
>
> https://review.openstack.org/66717
>
>
>
> It’s be good if we can get those reviewed soon.
>
>
>
> --
>
> Don Dugger
>
> "Censeo Toto nos in Kansa esse decisse." - D. Gale
>
> Ph: 303/443-3786
>
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140114/6b9dad81/attachment.html>
More information about the OpenStack-dev
mailing list