<div dir="ltr">Thanks Don for raising the point, I was about to send an email after finishing up to review.<div>To me, it appears I have to give -1 when either :</div><div> 1. Change is related to API documentation or WSGI framework. AIUI, Gantt will be plugged to Nova thanks to its RPC interface, it makes no sense to ship any API-related thing then. </div>
<div> 2. Gantt is importing Oslo libs from Nova. IMHO, it's error-prone as we don't manage Olso updates in the Gantt code</div><div> 3. Gantt is directly using Nova libs. </div><div><br></div><div>As per you said, I'm OK for not taking account of 3., provided there is a clear moment on when we begin to diverge code, but then we need to add nova trunk as dependency in gantt's requirements.txt</div>
<div><br></div><div>-Sylvain</div><div>(I'm in EU timezone, will have to leave in a few)</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2014/1/14 Dugger, Donald D <span dir="ltr"><<a href="mailto:donald.d.dugger@intel.com" target="_blank">donald.d.dugger@intel.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="#0563C1" vlink="#954F72">
<div>
<p class="MsoNormal"><span style="color:#1f497d">All-<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">I want to clear up some confusion I’m seeing in the reviews of these syncup patches. These patches merely bring recent changes from the nova tree over to the gantt tree. There is no attempt to actually change
the code for gantt, that is a separate task. Our first goal is to have the scheduler in gantt do exactly what the scheduler in nova does. We want to be able to reliably change nova to use the gantt source tree as a drop in replacement, get that working before
we start making gantt specific changes.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">The gantt tree probably has extra code that can be trimmed out later but, as long as that code exists in gantt I want to make it a synced up copy of the code in nova.<u></u><u></u></span></p>
<div class="im">
<p class="MsoNormal"><span style="color:#1f497d"><u></u> <u></u></span></p>
<div>
<p class="MsoNormal"><span style="color:#1f497d">--<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">Don Dugger<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">"Censeo Toto nos in Kansa esse decisse." - D. Gale<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">Ph: <a href="tel:303%2F443-3786" value="+13034433786" target="_blank">303/443-3786</a><u></u><u></u></span></p>
</div>
<p class="MsoNormal"><span style="color:#1f497d"><u></u> <u></u></span></p>
</div><div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Dugger, Donald D <br>
<b>Sent:</b> Tuesday, January 14, 2014 2:48 PM<br>
<b>To:</b> OpenStack Development Mailing List (not for usage questions)<br>
<b>Subject:</b> [gantt] Sync up patches<u></u><u></u></p>
</div>
</div><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">All-<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">As threatened, I’ve pushed 24 patches to sync up the gantt tree to recent changes to the nova tree. They’re all linked in a dependency chain starting at:<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"> <a href="https://review.openstack.org/66717" target="_blank">
https://review.openstack.org/66717</a><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">It’s be good if we can get those reviewed soon.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">--<u></u><u></u></p>
<p class="MsoNormal">Don Dugger<u></u><u></u></p>
<p class="MsoNormal">"Censeo Toto nos in Kansa esse decisse." - D. Gale<u></u><u></u></p>
<p class="MsoNormal">Ph: <a href="tel:303%2F443-3786" value="+13034433786" target="_blank">303/443-3786</a><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
</div></div></div>
</div>
<br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>