Open Stack

Andrew,
   While i agree there is a thought to change/improve this in future, but
the way it is today isn't acceptable, mainly bcos (as i said) the new
serverIP is taken effect w/o service restart and if someone adds -o
options.. even after service restart it doesn't take effect. Its confusing
to the admin (forget the user!) itself.. as to why serverIP change is
effected but -o options isn't. IMHO we should fix this that this works in a
sane way until the future when the rework / redesign happens... thanks
deepak


On Fri, Apr 11, 2014 at 7:31 PM, Kerr, Andrew <Andrew.Kerr at netapp.com>wrote:

> Hi Deepak,
>
> I know that there are plans to completely change how NFS uses (or more
> accurately, will not use) the shares.conf file in the future.  My guess is
> that a lot of this code will be changed in the near future during that
> rework.
>
> Andrew Kerr
> OpenStack QA
> Cloud Solutions Group
> NetApp
>
>
> From:  Deepak Shetty <dpkshetty at gmail.com>
> Reply-To:  "OpenStack Development Mailing List (not for usage questions)"
> <openstack-dev at lists.openstack.org>
> Date:  Friday, April 11, 2014 at 7:54 AM
> To:  "OpenStack Development Mailing List (not for usage questions)"
> <openstack-dev at lists.openstack.org>
> Subject:  [openstack-dev] [Cinder] XXXFSDriver: Query on usage
> of      load_shares_config in ensure_shares_mounted
>
>
> Hi,
>
>    I am using the nfs and glusterfs driver as reference here.
>
>
> I see that load_shares_config is called everytime via
> _ensure_shares_mounted which I feel is incorrect mainly because
> ensure_shares_mounted loads the config file again w/o restarting the
> service
>
>
> I think that the shares config file should only be loaded once (during
> service startup) as part of do_setup and never again.
>
> If someone changes something in the conf file, one needs to restart
> service which calls do_setup again and the changes made in shares.conf is
> taken effect.
>
>
> In looking further.. the ensure_shares_mounted ends up calling
> remotefsclient.mount() which does _Nothing_ if the share is already
> mounted.. whcih is mostly the case. So even if someone changed something
> in the shares file (like added -o options) it won't take
>  effect as the share is already mounted & service already running.
>
> In fact today, if you restart the service, even then the changes in share
> won't take effect as the mount is not un-mounted, hence when the service
> is started next, the mount is existing and ensures_shares_mounted just
> returns w/o doing anything.
>
>
> The only adv of calling load_shares_config in ensure_shares_mounted is if
> someone changed the shares server IP while the service is running ... it
> loads the new share usign the new server IP.. which again is wrong since
> ideally the person should restart service
>  for any shares.conf changes to take effect.
>
> Hence i feel callign load_shares_config in ensure_shares_mounted is
> Incorrect and should be removed
>
> Thoughts ?
>
> thanx,
>
> deepak
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140417/e0a6928f/attachment.html>