<div dir="ltr"><div>Andrew,<br></div> While i agree there is a thought to change/improve this in future, but the way it is today isn't acceptable, mainly bcos (as i said) the new serverIP is taken effect w/o service restart and if someone adds -o options.. even after service restart it doesn't take effect. Its confusing to the admin (forget the user!) itself.. as to why serverIP change is effected but -o options isn't. IMHO we should fix this that this works in a sane way until the future when the rework / redesign happens... thanks deepak<br>
<div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Apr 11, 2014 at 7:31 PM, Kerr, Andrew <span dir="ltr"><<a href="mailto:Andrew.Kerr@netapp.com" target="_blank">Andrew.Kerr@netapp.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Deepak,<br>
<br>
I know that there are plans to completely change how NFS uses (or more<br>
accurately, will not use) the shares.conf file in the future. My guess is<br>
that a lot of this code will be changed in the near future during that<br>
rework.<br>
<br>
Andrew Kerr<br>
OpenStack QA<br>
Cloud Solutions Group<br>
NetApp<br>
<br>
<br>
From: Deepak Shetty <<a href="mailto:dpkshetty@gmail.com">dpkshetty@gmail.com</a>><br>
Reply-To: "OpenStack Development Mailing List (not for usage questions)"<br>
<<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
Date: Friday, April 11, 2014 at 7:54 AM<br>
To: "OpenStack Development Mailing List (not for usage questions)"<br>
<<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
Subject: [openstack-dev] [Cinder] XXXFSDriver: Query on usage<br>
of load_shares_config in ensure_shares_mounted<br>
<div><div class="h5"><br>
<br>
Hi,<br>
<br>
I am using the nfs and glusterfs driver as reference here.<br>
<br>
<br>
I see that load_shares_config is called everytime via<br>
_ensure_shares_mounted which I feel is incorrect mainly because<br>
ensure_shares_mounted loads the config file again w/o restarting the<br>
service<br>
<br>
<br>
I think that the shares config file should only be loaded once (during<br>
service startup) as part of do_setup and never again.<br>
<br>
If someone changes something in the conf file, one needs to restart<br>
service which calls do_setup again and the changes made in shares.conf is<br>
taken effect.<br>
<br>
<br>
In looking further.. the ensure_shares_mounted ends up calling<br>
remotefsclient.mount() which does _Nothing_ if the share is already<br>
mounted.. whcih is mostly the case. So even if someone changed something<br>
in the shares file (like added -o options) it won't take<br>
effect as the share is already mounted & service already running.<br>
<br>
In fact today, if you restart the service, even then the changes in share<br>
won't take effect as the mount is not un-mounted, hence when the service<br>
is started next, the mount is existing and ensures_shares_mounted just<br>
returns w/o doing anything.<br>
<br>
<br>
The only adv of calling load_shares_config in ensure_shares_mounted is if<br>
someone changed the shares server IP while the service is running ... it<br>
loads the new share usign the new server IP.. which again is wrong since<br>
ideally the person should restart service<br>
for any shares.conf changes to take effect.<br>
<br>
Hence i feel callign load_shares_config in ensure_shares_mounted is<br>
Incorrect and should be removed<br>
<br>
Thoughts ?<br>
<br>
thanx,<br>
<br>
deepak<br>
<br>
<br>
</div></div>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><br></div></div></div></div>