[openstack-dev] [Cinder] XXXFSDriver: Query on usage of load_shares_config in ensure_shares_mounted

Duncan Thomas duncan.thomas at gmail.com
Fri Apr 11 14:07:23 UTC 2014


Hi Deepak

Both of those (config being read repeatedly, and config not being
applied if the share is already mounted) sound like bugs. Please file
bug reports for both, with reproducers if possible.

Thanks

On 11 April 2014 12:54, Deepak Shetty <dpkshetty at gmail.com> wrote:
> Hi,
>    I am using the nfs and glusterfs driver as reference here.
>
> I see that load_shares_config is called everytime via _ensure_shares_mounted
> which I feel is incorrect mainly because ensure_shares_mounted loads the
> config file again w/o restarting the service
>
> I think that the shares config file should only be loaded once (during
> service startup) as part of do_setup and never again.
>
> If someone changes something in the conf file, one needs to restart service
> which calls do_setup again and the changes made in shares.conf is taken
> effect.
>
> In looking further.. the ensure_shares_mounted ends up calling
> remotefsclient.mount() which does _Nothing_ if the share is already
> mounted.. whcih is mostly the case. So even if someone changed something in
> the shares file (like added -o options) it won't take effect as the share is
> already mounted & service already running.
>
> In fact today, if you restart the service, even then the changes in share
> won't take effect as the mount is not un-mounted, hence when the service is
> started next, the mount is existing and ensures_shares_mounted just returns
> w/o doing anything.
>
> The only adv of calling load_shares_config in ensure_shares_mounted is if
> someone changed the shares server IP while the service is running ... it
> loads the new share usign the new server IP.. which again is wrong since
> ideally the person should restart service for any shares.conf changes to
> take effect.
>
> Hence i feel callign load_shares_config in ensure_shares_mounted is
> Incorrect and should be removed
>
> Thoughts ?
>
> thanx,
> deepak
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
--
Duncan Thomas



More information about the OpenStack-dev mailing list