Open Stack

On 04/08/2014 06:16 AM, Day, Phil wrote:
>> https://bugs.launchpad.net/nova/+bug/1303983
>>
>> --
>> Russell Bryant
> 
> Wow - was there really a need to get that change merged within 12 hours and before others had a chance to review and comment on it ?

It was targeted against RC2 which we're trying to get out ASAP.  The
change is harmless.

> I see someone has already queried (post the merge) if there isn't a performance impact.

The commit message indicates that when the API is not used, the
scheduler filters are a no-op.  There is no noticable performance impact.

> I've raised this point before - but apart from non-urgent security fixes shouldn't there be a minimum review period to make sure that all relevant feedback can be given ?

Separate topic, but no, I do not think there should be any rules on
this.  I think in the majority of cases, people do the right thing.

In this case, the patch was incredibly trivial and has no performance
impact, so I don't see anything wrong.

-- 
Russell Bryant