Open Stack

2014-04-08 20:08 GMT+08:00 Russell Bryant <rbryant at redhat.com>:

> On 04/08/2014 06:16 AM, Day, Phil wrote:
> >> https://bugs.launchpad.net/nova/+bug/1303983
> >>
> >> --
> >> Russell Bryant
> >
> > Wow - was there really a need to get that change merged within 12 hours
> and before others had a chance to review and comment on it ?
>
> It was targeted against RC2 which we're trying to get out ASAP.  The
> change is harmless.
>
> > I see someone has already queried (post the merge) if there isn't a
> performance impact.
>
> The commit message indicates that when the API is not used, the
> scheduler filters are a no-op.  There is no noticable performance impact.
>
Thanks Russell, I asked the performance question in the gerrit review. Just
checked the logic again and did not found any potential performance issue.

>
> > I've raised this point before - but apart from non-urgent security fixes
> shouldn't there be a minimum review period to make sure that all relevant
> feedback can be given ?
>
> Separate topic, but no, I do not think there should be any rules on
> this.  I think in the majority of cases, people do the right thing.
>
> In this case, the patch was incredibly trivial and has no performance
> impact, so I don't see anything wrong.
>
> --
> Russell Bryant
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Thanks,

Jay
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140408/48152af7/attachment.html>