[Openstack] Duplication of code in nova and cinder

Joshua Harlow harlowja at yahoo-inc.com
Wed Dec 12 00:56:33 UTC 2012

Related to this, how do we in the future stop such code-copying from happening in the first place?

Is it just that there needs to be a place for this (oslo?) that can be updated more quickly, or something similar?

I'm always sorta 'weirded out' when people say that they copied some code in the name of 'it was quicker' or we are just 'borrowing it'.

From: John Griffith <john.griffith at solidfire.com<mailto:john.griffith at solidfire.com>>
Date: Tuesday, December 11, 2012 3:36 PM
To: Sam Morrison <sorrison at gmail.com<mailto:sorrison at gmail.com>>
Cc: OpenStack mailing list <openstack at lists.launchpad.net<mailto:openstack at lists.launchpad.net>>
Subject: Re: [Openstack] Duplication of code in nova and cinder

On Tue, Dec 11, 2012 at 4:24 PM, Sam Morrison <sorrison at gmail.com<mailto:sorrison at gmail.com>> wrote:
I attempted to create a volume from an image in cinder and was getting this strange error, turns out it was because I had my glance servers specified as https://glanceserver:9292

In cinder the version of images/glance.py is older than the one in nova and is missing the ssl support additions.

My real question is why is there one version is nova and one version in cinder. I also think there is quite a bit more unnecessary duplication.
Should it all go into oslo?


Mailing list: https://launchpad.net/~openstack
Post to     : openstack at lists.launchpad.net<mailto:openstack at lists.launchpad.net>
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp
Hi Sam,

Short answer is "yes".  Need to check scoping etc and make sure that it does in fact fit within the parameters of OSLO.  It's something I thought of a couple weeks ago but to be honest it's been low on my list personally and nobody else that I know of has shown an interest in picking it up.

You'll notice another image related item we're *borrowing* from Nova (cinder.image.image_utils).  In both cases there are slight modifications to fit Cinder's use case that given a bit of work could easily be shared.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack/attachments/20121211/8c66d1f5/attachment.html>

More information about the Openstack mailing list