[OpenStack-Infra] git-review 1.26 release

Zaro zaro0508 at gmail.com
Tue Mar 29 20:07:40 UTC 2016


Just a note, I think this change to fix tests would be very helpful:
https://review.openstack.org/#/c/285620/

This change allows running git-review tests on OSX.

-Khai

On Mon, Mar 28, 2016 at 12:06 PM, Jeremy Stanley <fungi at yuggoth.org> wrote:
> On 2016-03-28 09:41:59 -0700 (-0700), Zaro wrote:
>> would be nice to include the change to set WIP on push:
>> https://review.openstack.org/281504
>
> I don't believe there was ever consensus on this since there was no
> generic Gerrit-independent solution for work in progress
> (recommended to be a Gerrit plug-in instead). I'm tempted to just
> expect it to detect and support the WIP plug-in rather than our
> hackish WIP-by-label workaround, and work on converting our current
> deployment to use the plug-in once it's ready.
>
> New features, if they can be justified (like supporting Gerrit's
> upcoming "signed push" detection as was mentioned in IRC earlier
> today), should be considered _after_ we release but I'm still not
> keen on adding features unless they really make sense to most
> typical Gerrit deployments and represent basic functionality we
> expect most users to need/understand.
>
> I'd like to make sure we avoid adding advanced features easily
> handled by existing tools (especially Git), or relying on unusual
> Gerrit configurations/deployment choices.
> --
> Jeremy Stanley
>
> _______________________________________________
> OpenStack-Infra mailing list
> OpenStack-Infra at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra



More information about the OpenStack-Infra mailing list