Open Stack

Hi Kien,

What I thought is the changes made to convert to xml function have been
updated to a lot of plugins, also some plugins have not been updated. So if
we have a spec to keep why and how to use the convert to xml function and
which plugins have been updated, which not, it will be great. But it's not
must needed, just my opinion.

Thanks,
Dong

2016-07-06 14:20 GMT+08:00 Kien Ha <kienha9922 at gmail.com>:

> Hi Dong,
>
> Looks like I misinterpreted what you mean the first time around, sorry
> about that. To clarify, did you mean to keep track of changes made to
> convert to xml function or to keep track of the plugins that have been
> updated to use the function? If it is wanted, I can go ahead and start
> adding it to the commit messages.
>
> Thanks,
> Kien
>
> On Sun, Jul 3, 2016 at 5:13 AM, Dong Ma <winterma.dong at gmail.com> wrote:
>
>> Hey Darragh and Kien,
>>
>> What I proposed is to create a etherpad/spec/blueprint to cover these
>> changes of using the convert to xml function in JJB, and include it in the
>> commit message as reference to keep tracking the process, so if someone
>> else would like to contribute, it will be easy to find it.
>>
>> Yes, include the document link into the commit message is not a good
>> commit message, I agree to keep the commits describing the functional
>> reason.
>>
>> Thanks,
>> Vincent
>>
>> 2016-07-01 22:25 GMT+08:00 Darragh Bailey <daragh.bailey at gmail.com>:
>>
>>> Hi Kien,
>>>
>>>
>>> I missed this email, but spotted this appearing in recent commits.
>>>
>>>
>>> On 13 June 2016 at 03:28, Kien Ha <kienha9922 at gmail.com> wrote:
>>>
>>>>
>>>> On Sat, Jun 11, 2016 at 11:12 PM, Dong Ma <winterma.dong at gmail.com>
>>>> wrote:
>>>>
>>>>> Hello Kien Ha,
>>>>>
>>>>> Thanks for the contribution to the Jenkins job builder projects, have
>>>>> one comment here, how about add your proposal document link or create a new
>>>>> etherpad into the commit message of each patches as reference to keep
>>>>> tracking the process.
>>>>>
>>>>> Vincent
>>>>>
>>>>
>>> This kind goes outside of what is generally described as
>>> https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages
>>>
>>>
>>> The update to the mailing list is more than enough, let's keep the
>>> commits describing the functional reason for the change, or if there is a
>>> separate proposal spec/blueprint that covers changing to use the convert to
>>> xml function in JJB, changes relevant can include a reference, otherwise
>>> lets keep the commit messages focused on the change itself.
>>>
>>>
>>> --
>>> Darragh Bailey
>>> "Nothing is foolproof to a sufficiently talented fool"
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-infra/attachments/20160706/9dee003a/attachment.html>