[OpenStack-Infra] vcsrepo upstream
Marton Kiss
marton.kiss at gmail.com
Wed Sep 23 07:40:38 UTC 2015
I was playing with an alternative workaround, where the askbot exec
resources extended with a conditional check of git HEAD status. I made a
quick poc, you can find it here:
https://github.com/mkissam/puppet-vcsrepo-refresh-poc/blob/master/vcsrepo-refresh-workaround.md
The test results are the following:
pros:
- it is skipping the execution of exec commands when the git HEAD was not
changed since the last successfull run
cons:
- it is doing the command exception skip in a silent way, and it is
impossible to determine from the report whether the command was executed or
not
- the report is still full with refresh event triggers on dependent
resources
So my personal opinion that this workaround not solves our original problem
of refresh event triggers, basically it is working, but totally hiding
relevant information, and makes later debugging or problem discovery
impossible.
If we fear that switching to upstream vcsrepo, or even back porting the fix
from upstream can harm our existing infrastructure, I suggest to finish the
puppet-git module suggested by Colleen, deploy it next to our vcsrepo
module in system-config. So we can easily switch on a per-project basic,
and won't risk ruining the whole infrastructure.
Brgds,
Marton
On Wed, Sep 16, 2015 at 8:48 PM Marton Kiss <marton.kiss at gmail.com> wrote:
> Colleen,
>
> Thank you for the infos, sowe have three options now, and
> - openstack-infra/puppet-vcsrepo requires a patch backport
> - puppet-community/puppet-git_resource require some extra work
> - upstream puppet-vcsrepo: what are the arguments against that?
>
> M.
>
> On Wed, Sep 16, 2015 at 8:23 PM Colleen Murphy <colleen at gazlene.net>
> wrote:
>
>> On Wed, Sep 16, 2015 at 11:12 AM, Marton Kiss <marton.kiss at gmail.com>
>> wrote:
>>
>>> Hi Colleen,
>>>
>>> Have you ever tried this puppet-community puppet-git_resource module? It
>>> seems to be that it is not ready, the resource auto-depends on a git class
>>> here:
>>>
>>> https://github.com/puppet-community/puppet-git_resource/blob/04ec35488c4d0d5374c736daa4a7e89fbf3e8d84/lib/puppet/type/git.rb#L86
>>>
>>> but it was never declared anywhere, the whole manifests directory is
>>> missing from the repo. (it was present in nanliu's version)
>>>
>>> Brgds,
>>> Marton
>>>
>> I've not personally used it, no.
>>
>> An autorequire will add a require relationship to a resource only if that
>> resource is in the catalog, so autorequiring a class that is no longer in
>> the module will not cause any problems.
>>
>> I have not seen the discussion, but what I suspect happened is that there
>> is another module from puppetlabs that is also called 'git', but it manages
>> the installation and configuration of git, not git repositories. I expect
>> they renamed the module and removed the class in order to be compatible
>> with the other module.
>>
>> #puppet-community would be a good place to inquire about this module.
>>
>> Colleen
>> _______________________________________________
>> OpenStack-Infra mailing list
>> OpenStack-Infra at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-infra/attachments/20150923/4b0a95c8/attachment.html>
More information about the OpenStack-Infra
mailing list