<div dir="ltr">I was playing with an alternative workaround, where the askbot exec resources extended with a conditional check of git HEAD status. I made a quick poc, you can find it here:<div><a href="https://github.com/mkissam/puppet-vcsrepo-refresh-poc/blob/master/vcsrepo-refresh-workaround.md">https://github.com/mkissam/puppet-vcsrepo-refresh-poc/blob/master/vcsrepo-refresh-workaround.md</a></div><div><br></div><div>The test results are the following:</div><div>pros:</div><div> - it is skipping the execution of exec commands when the git HEAD was not changed since the last successfull run</div><div>cons:</div><div> - it is doing the command exception skip in a silent way, and it is impossible to determine from the report whether the command was executed or not</div><div> - the report is still full with refresh event triggers on dependent resources</div><div><br></div><div>So my personal opinion that this workaround not solves our original problem of refresh event triggers, basically it is working, but totally hiding relevant information, and makes later debugging or problem discovery impossible.</div><div><br></div><div>If we fear that switching to upstream vcsrepo, or even back porting the fix from upstream can harm our existing infrastructure, I suggest to finish the puppet-git module suggested by Colleen, deploy it next to our vcsrepo module in system-config. So we can easily switch on a per-project basic, and won't risk ruining the whole infrastructure.</div><div><br></div><div>Brgds,</div><div> Marton<br><br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 16, 2015 at 8:48 PM Marton Kiss <<a href="mailto:marton.kiss@gmail.com">marton.kiss@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Colleen,<div><br></div><div>Thank you for the infos, sowe have three options now, and</div><div>- openstack-infra/puppet-vcsrepo requires a patch backport</div><div>- puppet-community/puppet-git_resource require some extra work</div><div>- upstream puppet-vcsrepo: what are the arguments against that?</div></div><div dir="ltr"><div><br></div><div>M.</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 16, 2015 at 8:23 PM Colleen Murphy <<a href="mailto:colleen@gazlene.net" target="_blank">colleen@gazlene.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Sep 16, 2015 at 11:12 AM, Marton Kiss <span dir="ltr"><<a href="mailto:marton.kiss@gmail.com" target="_blank">marton.kiss@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Colleen,<div><br></div><div>Have you ever tried this puppet-community puppet-git_resource module? It seems to be that it is not ready, the resource auto-depends on a git class here:</div><div><a href="https://github.com/puppet-community/puppet-git_resource/blob/04ec35488c4d0d5374c736daa4a7e89fbf3e8d84/lib/puppet/type/git.rb#L86" target="_blank">https://github.com/puppet-community/puppet-git_resource/blob/04ec35488c4d0d5374c736daa4a7e89fbf3e8d84/lib/puppet/type/git.rb#L86</a><br></div><div><br></div><div>but it was never declared anywhere, the whole manifests directory is missing from the repo. (it was present in nanliu's version)</div><div><br></div><div>Brgds,</div><div> Marton</div></div></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>I've not personally used it, no.</div><div><br></div><div>An autorequire will add a require relationship to a resource only if that resource is in the catalog, so autorequiring a class that is no longer in the module will not cause any problems.</div><div><br></div><div>I have not seen the discussion, but what I suspect happened is that there is another module from puppetlabs that is also called 'git', but it manages the installation and configuration of git, not git repositories. I expect they renamed the module and removed the class in order to be compatible with the other module.</div><div><br></div><div>#puppet-community would be a good place to inquire about this module.</div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>Colleen</div></div></div></div>
_______________________________________________<br>
OpenStack-Infra mailing list<br>
<a href="mailto:OpenStack-Infra@lists.openstack.org" target="_blank">OpenStack-Infra@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra</a><br>
</blockquote></div></blockquote></div></div></div>