[OpenStack-Infra] enforce bug ids in commit message

Sean_McGinnis at DELL.com Sean_McGinnis at DELL.com
Thu Mar 19 05:58:16 UTC 2015


Dell - Internal Use - Confidential 

I agree with Jeremy. My approach has been if it's addressing a problem or it is a significant enough change that needs some additional background beyond what can be put in a commit message then it makes sense to create a bug.

If it's just something small like cleaning up some code or to make some minor improvements I don't think it makes sense to require a bug to be filed for that. I would also consider that being busywork.

The main benefit I see of having a bug filed is others can find it and know if something they are seeing is being addressed. I don't think it would give much benefit to others to see a bug for something like me improving some logging messages or something like that.

I would rather see the effort focused on making sure folks write decent commit messages than whether or not they've filled out the proper paperwork.

-----Original Message-----

On 2015-03-18 16:38:02 +0530 (+0530), Vinay Mahuli wrote:
> How to enforce users to put the "bug ids" in the review commits? A
> user shouldn't be able to raise a review request if the user
> hasn't put the corresponding "bug id" in the commit message.

Is every code change necessarily fixing a bug? I worry this
stretches the meaning of the word "bug" if so. As long as a commit
message adequately describes its reason for existing, I don't see
why it's necessary to force the busywork of duplicating the same
information into a separate system.
-- 
Jeremy Stanley 



More information about the OpenStack-Infra mailing list