Open Stack

Antoine, Arx:

Thanks, the change in the comment-filter (...Patch Set [0-9]...) did the trick!

Thanks for your help!!!

-Dane

-----Original Message-----
From: Antoine Musso [mailto:hashar at free.fr] 
Sent: Friday, May 02, 2014 5:13 PM
To: Dane Leblanc (leblancd); openstack-infra at lists.openstack.org
Subject: Re: [OpenStack-Infra] [openstack-dev] [infra] zuul layout.yaml config for trigger on rechecks

Le 02/05/2014 20:16, Dane Leblanc (leblancd) a écrit :
> I've set up the gerrit trigger in the layout.yaml with regex's which I 
> believe should match the recheck comments.  The layout.yaml is listed 
> in this paste:
> 
>      http://paste.openstack.org/show/78504/
> 
> The layout.yaml works perfectly for "patchset-created" events. 
> However, for "comment-added" events with comments of the expected form 
> ("recheck ."), I'm not seeing any jobs triggered from the 
> IndependentPipelineManager.  I've included a snippet from the 
> debug.log for a sample "recheck cisco" comment.

Hello Dane,

>From your paste:

  trigger:
    gerrit:
      - event: comment-added
          comment_filter: (?i)^\s*recheck cisco\s*$

That regex does not match because some Gerrit version changed the message sent over JSON and prefix them with  'Patchset X: '.

Khai Do spotted it during the Gerrit tests and sent a patch to OpenStack Zuul configuration [change 70864]

So you will want:

 comment_filter: (?i)^Patchset [0-9]+:\n\n\s*recheck cisco\s*$



References:

Openstack regex:

  comment_filter: (?i)^(Patch Set [0-9]+:\n\n)?\s*recheck(( (?:bug|lp)[\s#:]*(\d+))|( no bug))\s*$


Khai Do [change 70864]:
https://review.openstack.org/#/c/70864/5/modules/openstack_project/files/zuul/layout.yaml,unified




--
Antoine "hashar" Musso