[OpenStack-Infra] check pipeline triggered when comments are added

Michael Still mikal at stillhq.com
Tue Mar 4 10:02:13 UTC 2014


Yes. Patches with very old checks were hitting the merge pipeline,
where their failure was very expensive. Instead, they get rechecked
every few days to ensure the author knows when the patch has zero
chance of merging.

Michael

On Tue, Mar 4, 2014 at 8:31 PM, Antoine Musso <hashar at free.fr> wrote:
> Hello,
>
> For a couple weeks I noticed the Zuul 'check' pipeline is being
> triggered when adding a single comment on an old patch.
>
> I find it annoying when a patchset review takes a couple weeks or so.
> The review would usually lead to a new patchset and I don't think the
> intermediary checks are necessary
>
> I think it is caused by: https://review.openstack.org/#/c/73418/ which adds:
>
>  trigger:
>    gerrit:
>      - event: comment-added
>        require-approval:
>          - username: 'jenkins'
>            older-than: 72h
>
> Any reason for that?
>
> --
> Antoine "hashar" Musso
>
> _______________________________________________
> OpenStack-Infra mailing list
> OpenStack-Infra at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra



-- 
Rackspace Australia



More information about the OpenStack-Infra mailing list