[OpenStack-Infra] disable full recheck if only the commit message changed

Jeremy Stanley fungi at yuggoth.org
Fri Jun 6 12:06:06 UTC 2014


On 2014-06-06 08:33:52 +0200 (+0200), Christian Berendt wrote:
> Shouldn't we disable the full recheck of a review request when
> only the commit message changed? I think it's sufficient to check
> the commit message itself without rechecking the whole review
> request.

Changing the commit message changes the Git SHA of the commit, and
Gerrit reports this in its event stream as a distinct patchset. Zuul
would need to retrieve previous and current patchsets on every event
and compare them... I'm not sure the relatively minimal savings
would be worth the additional complexity, though others may
disagree.

This should probably be tracked as a feature request to
openstack-infra/zuul at low or wishlist priority.
-- 
Jeremy Stanley



More information about the OpenStack-Infra mailing list