Open Stack

On 02/20/2015 07:50 PM, Jeremy Stanley wrote:
> On 2015-02-20 12:52:40 -0500 (-0500), Nick Chase wrote:
> [...]
>> To solve this problem, I would like to suggest that rather than
>> -1'ing the patch, these patches be approved with an understanding
>> that a separate bug will be filed to "clean up" the content.
> [...]
> 
> What I tend to do (for Infra patches, so YMMV) is if the patch is
> fine other than a few cosmetic nits, I upload the corrections I
> would like to see and then +2 my update. If there was already an
> existing +2 on the change then I also approve when I do that and
> just leave a comment that I made cosmetic improvements and was
> basing approval on another core reviewer's +2 from the prior
> patchset. This both short-circuits the delays from back-and-forth
> over mostly inconsequential polish, while also placing the burden on
> _me_ as a reviewer to solve the problems I have with the patch that
> perhaps another core reviewer wasn't quite so deterred by.


Indeed that's a nice way of doing it - this avoids accumlation of
technical debt,

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
       Graham Norton, HRB 21284 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126