[Openstack-docs] Minimum time before approving a review request

Tom Fifield tom at openstack.org
Tue Sep 9 00:37:47 UTC 2014


On 09/09/14 03:19, Andreas Jaeger wrote:
> On 09/08/2014 08:57 PM, Matt Kassawara wrote:
>> I agree with Anne and Nick. In the case of questionable content, most of
>> us tag other reviewers and wait a certain amount of time for them to
>> review the patch. Also, larger patches already tend to remain in the
>> review queue for a reasonable amount of time.
>>
> 
> For patches where we need more discussion, most of us add a comment
> stating so.
> 
> Having a quick turnaround is IMHO one of our great benefits great and
> gives contributors a really good experience.
> 
> If something goes in that's wrong, we can also easily revert ;)
> 
> I review many patches - and I'm glad for those that I never see because
> others reviewed them before me ;)

+1

This was discussed in the python projects and the conclusion was: don't
have a minimum time before approving a review request. Instead, common
sense and reverts as needed.

Regards,

Tom




More information about the Openstack-docs mailing list