Open Stack

I agree with Anne and Nick. In the case of questionable content, most of us
tag other reviewers and wait a certain amount of time for them to review
the patch. Also, larger patches already tend to remain in the review queue
for a reasonable amount of time.

On Mon, Sep 8, 2014 at 1:41 PM, Nicholas Chase <nchase at mirantis.com> wrote:

>
> On 9/8/2014 2:30 PM, Anne Gentle wrote:
>
>
> On Mon, Sep 8, 2014 at 1:23 PM, Christian Berendt <berendt at b1-systems.de>
> wrote:
>
>> I would like to propose the introduction of a minimum time before
>> approving a new review request.
>>
>> Example: https://review.openstack.org/#/c/119783/
>>
>> Uploaded: Sep 8, 2014 4:59 PM
>> First +2: 6:10 PM
>> Second +2: 8:15 PM
>> Approval: 8:16 PM
>>
>> I think we should wait at least 24 hours before approving a new review
>> request (exception: urgent or generated changes). This way everybody of
>> us has the chance to realize and review new review requests.
>>
>>
>  Interesting proposal, we did not address in
> https://wiki.openstack.org/wiki/Documentation/ReviewGuidelines -- my
> feeling is that we can't all review all patches so it's better to not
> enforce a minimum wait time. The impatience people have with our reviews
> should be reversed and we shouldn't have a policy of an enforced wait time.
>
>  To me, it's preferred to have hundreds of patches go through efficiently
> rather than ensure everyone sees every patch.
>
>  Just my thinking though, would love to hear what others have to say.
>
>
> I think that it's a good thought to make sure that patches have enough
> oversight, but it's unrealistic to have "everybody" look at a patch;
> there's just not enough time, as evidenced by the backlog we already have.
> If a patch goes through and someone has a concern, opening a new bug is
> just a button-click away.
>
> I also agree that people (all over OpenStack, not just in Docs) are
> already frustrated enough with the review process. ENSURING that it takes a
> day will only make things worse, I would think.
>
> But perhaps if there's a patch that people are concerned about -- say
> something major is going on -- there's a way for us to flag it, or maybe
> just to have the cores to +1 it temporarily just to show that they're in
> favor, while it's being further reviewed?
>
> ----  Nick
>
> --
> Nick Chase
> 1-650-567-5640
> Technical Marketing Manager, Mirantis
> Editor, OpenStack:Now
>  <http://openstacksv.com>
>
> _______________________________________________
> Openstack-docs mailing list
> Openstack-docs at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-docs/attachments/20140908/6a8b1dbf/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: www.openstacksv.com_.png
Type: image/png
Size: 7160 bytes
Desc: not available
URL: <http://lists.openstack.org/pipermail/openstack-docs/attachments/20140908/6a8b1dbf/attachment-0001.png>