On Mon, Sep 8, 2014 at 1:23 PM, Christian Berendt <berendt at b1-systems.de> wrote: > I would like to propose the introduction of a minimum time before > approving a new review request. > > Example: https://review.openstack.org/#/c/119783/ > > Uploaded: Sep 8, 2014 4:59 PM > First +2: 6:10 PM > Second +2: 8:15 PM > Approval: 8:16 PM > > I think we should wait at least 24 hours before approving a new review > request (exception: urgent or generated changes). This way everybody of > us has the chance to realize and review new review requests. > > Interesting proposal, we did not address in https://wiki.openstack.org/wiki/Documentation/ReviewGuidelines -- my feeling is that we can't all review all patches so it's better to not enforce a minimum wait time. The impatience people have with our reviews should be reversed and we shouldn't have a policy of an enforced wait time. To me, it's preferred to have hundreds of patches go through efficiently rather than ensure everyone sees every patch. Just my thinking though, would love to hear what others have to say. Anne > Christian. > > -- > Christian Berendt > Cloud Solution Architect > Mail: berendt at b1-systems.de > > B1 Systems GmbH > Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de > GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537 > > _______________________________________________ > Openstack-docs mailing list > Openstack-docs at lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstack.org/pipermail/openstack-docs/attachments/20140908/805cc4f8/attachment-0001.html>