Open Stack

On 07/31/2014 08:52 PM, Anne Gentle wrote:
> 
> 
> 
> On Thu, Jul 31, 2014 at 3:26 AM, Christian Berendt
> <berendt at b1-systems.de <mailto:berendt at b1-systems.de>> wrote:
> 
>     Hello.
> 
>     At https://review.openstack.org/#/c/109559/ I proposed a review request
>     to change the nicencess checks to vote for all our documents. At the
>     moment all documents are clean. We normally -1 changes with a failed
>     niceness check.
> 
>     Anne asked me to ask the list for their opinion.
> 
> 
> Yep, thanks Christian.
> 
> If my memory serves, Tom was quite unhappy with the original whitespace
> gate as he struggled to help newcomers pass the gate. If we all think
> that problem is resolved, I'm fine with gating on whitespace
> infractions. I'm not a super fan, since it slows down patch merges, but
> if it's the way we're shifting as a team, I'm good with it.

We review this way already and I don't see major problems, so I'm fine
with enabling it. And if it really hurts us, we can reverse that also ;)

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126