[Openstack-docs] Voting of nicencess checks
Anne Gentle
anne at openstack.org
Thu Jul 31 18:52:28 UTC 2014
On Thu, Jul 31, 2014 at 3:26 AM, Christian Berendt <berendt at b1-systems.de>
wrote:
> Hello.
>
> At https://review.openstack.org/#/c/109559/ I proposed a review request
> to change the nicencess checks to vote for all our documents. At the
> moment all documents are clean. We normally -1 changes with a failed
> niceness check.
>
> Anne asked me to ask the list for their opinion.
>
>
Yep, thanks Christian.
If my memory serves, Tom was quite unhappy with the original whitespace
gate as he struggled to help newcomers pass the gate. If we all think that
problem is resolved, I'm fine with gating on whitespace infractions. I'm
not a super fan, since it slows down patch merges, but if it's the way
we're shifting as a team, I'm good with it.
Anne
> Christian.
>
> --
> Christian Berendt
> Cloud Computing Solution Architect
> Mail: berendt at b1-systems.de
>
> B1 Systems GmbH
> Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de
> GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537
>
> _______________________________________________
> Openstack-docs mailing list
> Openstack-docs at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-docs/attachments/20140731/fa9f15f4/attachment.html>
More information about the Openstack-docs
mailing list