Open Stack

> osprofiler is not I requirements at all
I meant to say, is that opentelemetry is not in requirements of osprofiler

On Fri, Sep 1, 2023, 09:11 Dmitriy Rabotyagov <noonedeadpunk at gmail.com>
wrote:

> What is extremely weird for me, is that osprofiler is not I requirements
> at all - only in test-requirements, which should mean that it should not be
> required anywhere except for package testing? Though I see from code, that
> osprofiler will just fail with ImportError if opentelemetry is absent,
> which IMO is quite wrong from the beginning.
>
> And indeed that would make sense to me to use extras_require on setup.cfg
> to install only drivers that are needed, not * for each service.
>
> Though I am not sure who is motivated enough to invest time into that
> refactoring...
>
> On Fri, Sep 1, 2023, 08:54 Matthias Runge <mrunge at matthias-runge.de>
> wrote:
>
>> On 30/08/2023 11:11, Thomas Goirand wrote:
>> > Hi,
>> >
>> > I just saw that the last version of osprofiler requires
>> > opentelemetry-exporter-otlp and opentelemetry-sdk. Since osprofiler is
>> > used in almost all projects, and that opentelemetry is really HUGE, I
>> > wonder if this is all reasonable. This forces downstream distros to do
>> a
>> > lot of packaging only for that. Is this avoidable?
>> >
>> > I started doing the packaging, and then stopped to write this message,
>> > seeing how much work that would represent.
>>
>> Hi zigo,
>>
>> from what I have seen here (and you may remember talking about this when
>> we met at the OpenInfra Summit this year), the change makes sense to me.
>>
>> Quickly looking at [1], there may be the possibility to make it optional
>> though, and that would certainly make sense for the other drivers too.
>>
>> Matthias
>>
>>
>> [1]
>>
>> https://github.com/openstack/osprofiler/commit/908e7402320eb067db45aa9700d54d31c259f3ca
>> --
>> Matthias Runge <mrunge at matthias-runge.de>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.openstack.org/pipermail/openstack-discuss/attachments/20230901/3e74075e/attachment.htm>