Open Stack

The correct and only way to apply patches on images - is build them from
source. You should patch the code, not binary files.

On Wed, May 24, 2023 at 3:32 AM Satish Patel <satish.txt at gmail.com> wrote:

> This is very interesting that there is no standard or best way to patch
> images. Everyone uses their own way to handle it. Now I am very curious to
> see how folks running it in production with patching and building images. I
> am about to deploy kolla on production and trying to learn all best
> practices from experts.
>
> On Tue, May 23, 2023 at 7:47 PM Michal Arbet <michal.arbet at ultimum.io>
> wrote:
>
>> How ?
>>
>> Say to me please ? How you can patch oslo.messaging except template
>> override
>>
>> On Tue, May 23, 2023, 16:17 Danny Webb <Danny.Webb at thehutgroup.com>
>> wrote:
>>
>>> You can already do this with the kolla image builder which seems to me
>>> to be a much better solution than patching containers post creation.
>>> ------------------------------
>>> *From:* Michal Arbet <michal.arbet at ultimum.io>
>>> *Sent:* 23 May 2023 13:01
>>> *To:* openstack-discuss at lists.openstack.org <
>>> openstack-discuss at lists.openstack.org>
>>> *Subject:* Re: [kolla] How to patch images during build
>>>
>>>
>>> * CAUTION: This email originates from outside THG *
>>> ------------------------------
>>> I am very glad that someone asked for an option to patch kolla images.
>>> I've already proposed patches for kolla here [1] and here [2].
>>> But unfortunately I didn't get that many votes to merge into master and
>>> I abandoned this.
>>>
>>> [1] https://review.opendev.org/c/openstack/kolla/+/829296
>>> [2] https://review.opendev.org/c/openstack/kolla/+/829295
>>>
>>> With these above patches you can patch files inside every container.
>>> Maybe we can discuss this again ??
>>>
>>> For example now xena, yoga, zed, antelope has oslo.messaging broken :
>>>
>>> https://bugs.launchpad.net/oslo.messaging/+bug/2019978
>>> fixed by
>>> https://review.opendev.org/c/openstack/oslo.messaging/+/866617
>>>
>>> As I am using my kolla patches in my downstream kolla git repo i've only
>>> created patches/ directory and place fix for openstack-base container :)
>>>
>>> patches/
>>> patches/openstack-base
>>> patches/openstack-base/series
>>> patches/openstack-base/fix-rabbitmq-issue-opendev-883538.patch
>>>
>>> But, you still can use template-override
>>> https://docs.openstack.org/kolla/latest/admin/image-building.html .
>>>
>>> Thanks
>>>
>>> Michal Arbet
>>> Openstack Engineer
>>>
>>> Ultimum Technologies a.s.
>>> Na Poříčí 1047/26, 11000 Praha 1
>>> Czech Republic
>>>
>>> +420 604 228 897
>>> michal.arbet at ultimum.io
>>> *https://ultimum.io <https://ultimum.io/>*
>>>
>>> LinkedIn <https://www.linkedin.com/company/ultimum-technologies> |
>>> Twitter <https://twitter.com/ultimumtech> | Facebook
>>> <https://www.facebook.com/ultimumtechnologies/timeline>
>>>
>>>
>>> st 17. 5. 2023 v 20:19 odesílatel Jeremy Stanley <fungi at yuggoth.org>
>>> napsal:
>>>
>>> On 2023-05-17 21:02:02 +0300 (+0300), Maksim Malchuk wrote:
>>> > Yes, you can do that, but note bene mitaka not supported.
>>> [...]
>>>
>>> Not only unsupported, but the stable/mitaka branch of
>>> openstack/keystone was deleted when it reached EOL in 2017. You may
>>> instead want to specify `reference = mitaka-eol` (assuming Git tags
>>> also work there). That should get you the final state of the
>>> stable/mitaka branch prior to its deletion.
>>> --
>>> Jeremy Stanley
>>>
>>>

-- 
Regards,
Maksim Malchuk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.openstack.org/pipermail/openstack-discuss/attachments/20230524/78be1cd6/attachment.htm>