Open Stack

On 01/02, Radosław Piliszek wrote:
> Hello Fellow OpenStackers!
>
> I have noticed os-brick started using the file locks (in lock_path) to
> avoid race conditions.
> I have a question regarding that lock_path - it seems all the cases I
> have found use separate lock_paths per service, yet the problematic
> cases listed in the bug report (and the commit message of [1]) suggest
> that, in case of co-hosted nova-compute, glance-api, cinder-volume and
> cinder-backup services (or any combination thereof), the lock_path
> should be shared.
> Should the deployment projects adapt to actually fix the race condition issue?
>
> [1] https://review.opendev.org/c/openstack/os-brick/+/814139
>
> Kind regards,
> -yoctozepto
>

Hi,

Yes, it is the deployment tool's responsibility to set the right
lock_path value on the following cases:

- Hyperconverged deployment: Cinder-volume or cinder-backup are running
  on the same node as thee nova-compute service.

- Glance is using Cinder as a backend.

In all other cases it doesn't matter the value of the lock_path since
there only 1 project that uses os-brick, even if it has multiple
processes and/or services using it as is the case in cinder-volume and
cinder-backup running on the same host or cinder-backup running multiple
processes.

Cheers,
Gorka.