[cinder] Review of tiny patch to add Ceph RBD fast-diff to cinder-backup

Christian Rohmann christian.rohmann at inovex.de
Thu Feb 25 13:35:57 UTC 2021

Hey Brian,

On 23/02/2021 22:21, Brian Rosmaita wrote:
> On 2/23/21 12:08 PM, Christian Rohmann wrote:
>> On 18/02/2021 11:43, Christian Rohmann wrote:
>>> After some initial feedback, which I hopefully all fixed in my 
>>> updated patchset, the review of 
>>> (https://review.opendev.org/c/openstack/cinder/+/766856/)
>>> has stalled.
>>> Is there anything I would need to do to ask for this patch to be 
>>> considered for a merge?
>> Thanks for giving my patchset a +2.
>> I am now wondering what else is required for this to be merged to the 
>> next release?
>> Do I need to find another reviewer, do I need to add it to some list 
>> or will this get merged automatically?
> We'll discuss this at tomorrow's (wednesday 24 Feb) cinder meeting. 
> There is support for your patch, but maybe we shouldn't add a config 
> option but should just do the fast diff by default if the array 
> supports it and fall back to current behavior otherwise.
> But to answer your question, you would need another +2 on the patch 
> before it can be approved; once it's approved, it merges automatically 
> (more or less).

I uploaded a new Patchset now ... with the changes to enable fast-diff 
if available and I also added "backup" to the commit message.

Please kindly let me know if there is anything required to get this merged.



More information about the openstack-discuss mailing list